From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-104623-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 30264 invoked by alias); 24 Aug 2013 06:48:25 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 30250 invoked by uid 89); 24 Aug 2013 06:48:25 -0000
X-Spam-SWARE-Status: No, score=-4.1 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,SPF_SOFTFAIL autolearn=no version=3.3.2
Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sat, 24 Aug 2013 06:48:23 +0000
Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MS000100W7NWL00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Sat, 24 Aug 2013 09:48:21 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MS00019VW8KHKA0@a-mtaout20.012.net.il>; Sat, 24 Aug 2013 09:48:21 +0300 (IDT)
Date: Sat, 24 Aug 2013 06:48:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFA, doc RFA] Fix symtab/15885
In-reply-to: <yjt2txifrixw.fsf@ruffy.mtv.corp.google.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <834nafinyd.fsf@gnu.org>
References: <yjt2txifrixw.fsf@ruffy.mtv.corp.google.com>
X-SW-Source: 2013-08/txt/msg00717.txt.bz2

> From: Doug Evans <dje@google.com>
> Date: Fri, 23 Aug 2013 18:11:55 -0700
> 
> This patch fixes symtab/15885: gdb isn't using .gdb_index when it
> reloads symbols for a file.

Thanks.

> Index: NEWS
> ===================================================================
> RCS file: /cvs/src/src/gdb/NEWS,v
> retrieving revision 1.609
> diff -u -p -r1.609 NEWS
> --- NEWS	22 Aug 2013 20:32:54 -0000	1.609
> +++ NEWS	24 Aug 2013 00:55:05 -0000
> @@ -3,6 +3,8 @@
>  
>  *** Changes since GDB 7.6
>  
> +* The "maintenance print objfiles" command now takes an optional regexp.
> +
>  * The "catch syscall" command now works on arm*-linux* targets.
>  
>  * Python scripting

This part is OK.

> --- doc/gdb.texinfo	5 Aug 2013 15:39:25 -0000	1.1103
> +++ doc/gdb.texinfo	24 Aug 2013 00:55:06 -0000
> @@ -36820,10 +36820,11 @@ This command forces @value{GDBN} to flus
>  
>  @kindex maint print objfiles
>  @cindex info for known object files
> -@item maint print objfiles
> -Print a dump of all known object files.  For each object file, this
> -command prints its name, address in memory, and all of its psymtabs
> -and symtabs.
> +@item maint print objfiles [@var{regexp}]

This @item is in "@table @samp", which means each item is typeset in
monospaced font.  But we don't want the brackets [] to be in that
typeface, so please use

 @item maint print objfiles @r{[}@var{regexp}@r{]}

> +Print a dump of all known object files.
> +If @var{regexp} is specified, only print object files with names
                                                         ^^^^^^^^^^
I'd prefer "whose names" here, it removes a slight ambiguity in this
sentence.

OK with those changes.