From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-115636-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 27349 invoked by alias); 9 Sep 2014 14:34:55 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 27304 invoked by uid 89); 9 Sep 2014 14:34:55 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout25.012.net.il
Received: from mtaout25.012.net.il (HELO mtaout25.012.net.il) (80.179.55.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 09 Sep 2014 14:34:52 +0000
Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0NBN00J001KG1K00@mtaout25.012.net.il> for gdb-patches@sourceware.org; Tue, 09 Sep 2014 17:29:17 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NBN00HW81KT2K10@mtaout25.012.net.il>; Tue, 09 Sep 2014 17:29:17 +0300 (IDT)
Date: Tue, 09 Sep 2014 14:34:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH] New command: queue-signal
In-reply-to: <m37g1ft34v.fsf@sspiff.org>
To: Doug Evans <xdje42@gmail.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <834mwgc163.fsf@gnu.org>
References: <m37g1ft34v.fsf@sspiff.org>
X-IsSubscribed: yes
X-SW-Source: 2014-09/txt/msg00227.txt.bz2

> From: Doug Evans <xdje42@gmail.com>
> Date: Sun, 07 Sep 2014 16:36:00 -0700
> 
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -3,6 +3,11 @@
>  
>  *** Changes since GDB 7.8
>  
> +* New commands
> +
> +queue-signal signal-name-or-number
> +  Queue a signal to be delivered to the thread when it is resumed.
> +

This part is OK.

> +@kindex queue-signal
> +@item queue-signal @var{signal}
> +Queue signal @var{signal} to be delivered immediately to the current thread

You don't need the first "signal"; the second alone is enough.

> +The handling of the signal must be set to pass the signal to the program,
> +otherwise gdb will discard it when resuming the thread.  The handling of
             ^^^
@value{GDBN}

> +signals from @value{GDBN} is done with the @code{handle} command
                             ^^^^^^^
"is controlled" is better.  For bonus points, make this sentence use
active tense ("you can control ...").

> +Alternatively, if @var{signal} is zero, any currently queued signal is
> +discarded and when execution resumes no signal will be delivered.

Only to/for the current thread, right?  The text sounds much more
general than that, so I wonder.

> +  c = add_com ("queue-signal", class_run, queue_signal_command, _("\
> +Queue a signal to be delivered to the program when it is resumed.\n\
                                     ^^^^^^^^^^^
I suggest to say "the current thread" here.

The documentation parts are OK with these fixed.

Thanks.