Re: GDB 7.99.91 MinGW compilation error in cli-script.c

Pedro Alves
2017-05-25T10:12:24Z

On 05/24/2017 08:37 PM, Joel Brobecker wrote:

>> +2017-05-24 Eli Zaretskii <eliz@gnu.org>
>> +
>> + * common/common-utils.h (REPLACE_TO_STRING) [__MINGW32__]: Define
>> + to 1 if std::to_string is not available.

This:

>> + (std::to_string) [REPLACE_TO_STRING]: Provide a replacement
>> + implementation.

Should really be:

(gdb::to_string): Define.

and you need an entry for the cli/cli-script.c change, like:

* cli/cli-script.c (user_args::insert_args): Use it.

Otherwise this version of the patch is OK with me.

> Did we consider the option of perhaps only pushing this patch
> to the 8.0 branch, and require MinGW 5.x for the current master?
> If we did it that way, it would allow us to avoid remembering
> that we need to use gdb::to_string instead of std::to_string.

That'd be fine with me, FWIW.

Thanks,
Pedro Alves