Re: GDB 7.99.91 MinGW compilation error in cli-script.c

Joel Brobecker
2017-05-24T19:37:19Z

> Here's the final version; okay to commit?
>
> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> index a96e71f..d3a251b 100644
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -1,3 +1,10 @@
> +2017-05-24 Eli Zaretskii <eliz@gnu.org>
> +
> + * common/common-utils.h (REPLACE_TO_STRING) [__MINGW32__]: Define
> + to 1 if std::to_string is not available.
> + (std::to_string) [REPLACE_TO_STRING]: Provide a replacement
> + implementation.

Did we consider the option of perhaps only pushing this patch
to the 8.0 branch, and require MinGW 5.x for the current master?
If we did it that way, it would allow us to avoid remembering
that we need to use gdb::to_string instead of std::to_string.

--
Joel