Re: GDB 7.99.91 MinGW compilation warning in tui.c

Eli Zaretskii
2017-05-08T15:02:02Z

The warning manifests itself as follows:

g++ -std=gnu++11 -O2 -gdwarf-4 -g3 -I. -I. -I./common -I./config -DLOCALEDIR="\"d:/usr/share/locale\"" -DHAVE_CONFIG_H -I./../include/opcode -I./../opcodes/.. -I./../readline/.. -I../bfd -I./../bfd -I./../include -I../libdecnumber -I./../libdecnumber -I./gnulib/import -Ibuild-gnulib/import -DTUI=1 -Id:/usr/include -Id:/usr/include/guile/2.0 -Id:/usr/include -Id:/usr/Python26/include -Id:/usr/Python26/include -Wall -Wpointer-arith -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wempty-body -Wunused-but-set-parameter -Wunused-but-set-variable -Wno-sign-compare -Wno-narrowing -Wno-format -c -o tui.o -MT tui.o -MMD -MP -MF .deps/tui.Tpo tui/tui.c
tui/tui.c: In function 'void tui_enable()':
tui/tui.c:430:39: warning: ISO C++ forbids converting a string constant to 'char*' [-Wwrite-strings]
s = newterm ("unknown", stdout, stdin);
^
I fixed this by explicitly casting "unknown" to 'char *' -- is that
the right fix? Is it OK to push that fix?

Thanks.