Re: GDB 7.99.91 MinGW compilation error in cli-script.c

Eli Zaretskii
2017-05-26T07:47:05Z

> Cc: simon.marchi@polymtl.ca, gdb-patches@sourceware.org
> From: Pedro Alves <palves@redhat.com>
> Date: Thu, 25 May 2017 11:12:22 +0100
>
> This:
>
> >> + (std::to_string) [REPLACE_TO_STRING]: Provide a replacement
> >> + implementation.
>
> Should really be:
>
> (gdb::to_string): Define.

The code says std::to_string, though. So it sounds like some coding
conventions are being applied here of which I wasn't aware, and
neither is Emacs. Are these conventions described somewhere?

> and you need an entry for the cli/cli-script.c change, like:
>
> * cli/cli-script.c (user_args::insert_args): Use it.

I added that, but once again, the convention to put the
fully-qualified symbol name in the log entry should be documented, if
it isn't already, because Emacs doesn't do that, at least not by
default. Is this convention applied consistently across the project?

> > Did we consider the option of perhaps only pushing this patch
> > to the 8.0 branch, and require MinGW 5.x for the current master?
> > If we did it that way, it would allow us to avoid remembering
> > that we need to use gdb::to_string instead of std::to_string.
>
> That'd be fine with me, FWIW.

I wasn't sure what it means "to require MinGW 5.x", in practice, but I
pushed only to the branch for now.