Re: [PATCH 1/4] Implement 'set honor-dontdump-flag' command

Sergio Lopez
2017-11-28T15:06:09Z

On Tue, Nov 28, 2017 at 2:21 PM, Sergio Lopez <slp@redhat.com> wrote:
> + add_setshow_boolean_cmd ("honor-dontdump-flag", class_files,
> + &honor_dontdump_flag, _("\
> +Set whether gcore should honor the VM_DONTDUMP flag."),
> + _("\
> +Show whether gcore should honor the VM_DONTDUMP flag."),
> + _("\
> +Use this command to set whether gcore should honor the VM_DONTDUMP\n\
> +flag from /proc/PID/smaps when generating the corefile. For more information\n\
> +about this file, refer to the manpage of proc(5) and core(5)."),
> + NULL, show_use_coredump_filter,
> + &setlist, &showlist);
> }

A colleague spotted that I forgot to implement and use a different
"show" function for honor-dontdump-flag, wrongly reusing
show_use_coredump_filter.

I'm going to wait for feedback on the rest of the patchset. Will post
a v2 afterward.

--
Sergio