From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 104760 invoked by alias); 19 Dec 2017 16:33:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 104705 invoked by uid 89); 19 Dec 2017 16:33:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Hx-languages-length:1832 X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 19 Dec 2017 16:32:59 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eRKp3-0007ng-3Q for gdb-patches@sourceware.org; Tue, 19 Dec 2017 11:32:57 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34301) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eRKoz-0007k3-3z; Tue, 19 Dec 2017 11:32:49 -0500 Received: from [176.228.60.248] (port=2210 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eRKoy-0001BV-JT; Tue, 19 Dec 2017 11:32:49 -0500 Date: Tue, 19 Dec 2017 16:33:00 -0000 Message-Id: <834lomptj8.fsf@gnu.org> From: Eli Zaretskii To: Xavier Roirand CC: gdb-patches@sourceware.org, brobecker@adacore.com In-reply-to: <1513693765-20655-1-git-send-email-roirand@adacore.com> (message from Xavier Roirand on Tue, 19 Dec 2017 15:29:25 +0100) Subject: Re: [PATCH v2] (Ada) New command to stop at start of exception handlers. Reply-to: Eli Zaretskii References: <1513693765-20655-1-git-send-email-roirand@adacore.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00433.txt.bz2 > From: Xavier Roirand > Cc: Xavier Roirand , brobecker@adacore.com > Date: Tue, 19 Dec 2017 15:29:25 +0100 > > diff --git a/gdb/NEWS b/gdb/NEWS > index 44f481d..658d93a 100644 > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -665,6 +665,9 @@ show max-value-size > * Support for reading/writing memory and extracting values on architectures > whose memory is addressable in units of any integral multiple of 8 bits. > > +catch handlers > + Allows to break when an Ada exception is handled. > + > * New remote packets This part is OK. > +@cindex Ada exception handle catching You mean "handling", I believe, not "handle". Right? > +@cindex catch Ada exceptions when handled > +An Ada exception being handled. If an exception name is > +specified at the end of the command (eg @code{catch exception Program_Error}), "e.g.", and please use @kbd, not @code, when you mean something the user types as input. > +When inserting an handle catchpoint on a user-defined > +exception whose name is identical to one of the exceptions > +defined by the language, the fully qualified name must be used > +as the exception name. Otherwise, @value{GDBN} will assume that it > +should stop on the pre-defined exception rather than the > +user-defined one. For instance, assuming an exception called > + @code{Constraint_Error} is defined in package @code{Pck}, then the > +command to use to catch such exceptions handling is > +@kbd{catch handle Pck.Constraint_Error}. This is OK Texinfo-wise, but I wonder whether this default is useful. Why not default to the user-defined exception instead in such cases? (I'm not an Ada programmer, so apologies if this makes no sense.) The documentation parts are okay with the above nits fixed.