From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25418 invoked by alias); 21 Mar 2019 16:01:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25397 invoked by uid 89); 21 Mar 2019 16:01:10 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:865 X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Mar 2019 16:01:08 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51107) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h707t-0002LB-Ou; Thu, 21 Mar 2019 12:01:05 -0400 Received: from [176.228.60.248] (port=1711 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h707s-0005GH-W9; Thu, 21 Mar 2019 12:01:05 -0400 Date: Thu, 21 Mar 2019 16:01:00 -0000 Message-Id: <834l7wushq.fsf@gnu.org> From: Eli Zaretskii To: Simon Marchi CC: tom@tromey.com, gdb-patches@sourceware.org In-reply-to: (message from Simon Marchi on Thu, 21 Mar 2019 11:02:00 -0400) Subject: Re: [PATCH 00/16] Add styling to the gdb CLI and TUI References: <20181128001435.12703-1-tom@tromey.com> <83k1kxfzwo.fsf@gnu.org> <8736rja4i8.fsf@tromey.com> <83r2brhw8k.fsf@gnu.org> <87h8cmh1wg.fsf@tromey.com> <83va12gz8j.fsf@gnu.org> <87mumeb935.fsf@tromey.com> <83d0n8eyzw.fsf@gnu.org> <87d0n6adk2.fsf@tromey.com> <83imwyee29.fsf@gnu.org> <87d0n67d29.fsf@tromey.com> <83imwwc7pj.fsf@gnu.org> <57558f60-8254-931f-846b-bdd6b60f5798@simark.ca> <838sx8uwbb.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00459.txt.bz2 > Date: Thu, 21 Mar 2019 11:02:00 -0400 > From: Simon Marchi > Cc: tom@tromey.com, gdb-patches@sourceware.org > > > I don't have a strong opinion, but I do have a weak one: the decimal > > "encoding" makes it much easier for humans to construct version > > numbers, they don't need to convert to hex. > > There's not much difference in hex, you would just write "if > $_gdb_version >= 0x0901" for example, rather than "if $_gdb_version >= > 901". That's true for small values of major/minor. But imagine GDB 12.13 for a moment. > But again, my argument for hex is weak too, it's easy enough to extract > the GDB version components using some "% 100" and "/ 100". If there's > no more compelling argument for hex, I'm fine with decimal. Maybe someone else have an opinion on this? Thanks.