From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 115159 invoked by alias); 13 Sep 2019 07:28:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 115151 invoked by uid 89); 13 Sep 2019 07:28:42 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 13 Sep 2019 07:28:40 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48811) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1i8g0U-0006WB-VI; Fri, 13 Sep 2019 03:28:38 -0400 Received: from [176.228.60.248] (port=2211 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1i8g0U-0005LV-3V; Fri, 13 Sep 2019 03:28:38 -0400 Date: Fri, 13 Sep 2019 07:28:00 -0000 Message-Id: <834l1g1wp7.fsf@gnu.org> From: Eli Zaretskii To: andrew.burgess@embecosm.com CC: mgulick@mathworks.com, gdb-patches@sourceware.org In-reply-to: <835zlw1z45.fsf@gnu.org> (message from Eli Zaretskii on Fri, 13 Sep 2019 09:36:42 +0300) Subject: Re: [RFC] Apply compilation dir to source_path lookup References: <8058b501-9020-84f1-ecf4-b46bfe3b86e3@mathworks.com> <20190907235059.GN6076@embecosm.com> <4d9f4c81-8580-2b42-a434-389ed7655d7f@mathworks.com> <20190913013851.GT6076@embecosm.com> <835zlw1z45.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-09/txt/msg00235.txt.bz2 > Date: Fri, 13 Sep 2019 09:36:42 +0300 > From: Eli Zaretskii > CC: mgulick@mathworks.com, gdb-patches@sourceware.org > > > @value{GDBN} will also append the compilation > > +directory to the filename and check this against all other entries in > > +the source path. > > I think "append" here is a mistake. Should it be "prepend"? And > anyway, doesn't this simply repeat what was described in the text > above? Btw, do the "prepend" and "append", as implemented, take care to DTRT with Windows drive letters at the beginning of absolute file names? A literal prepending or appending will do the wrong thing there.