From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KBOzIrncbl8QOAAAWB0awg (envelope-from ) for ; Sat, 26 Sep 2020 02:16:25 -0400 Received: by simark.ca (Postfix, from userid 112) id 7C2561EF4D; Sat, 26 Sep 2020 02:16:25 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9C2831E509 for ; Sat, 26 Sep 2020 02:16:24 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0C4343857C61; Sat, 26 Sep 2020 06:16:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0C4343857C61 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1601100984; bh=X8M506qJSGiHyRc3CtupZ7vv4F7vdqlQi1IBVIhPFXw=; h=Date:To:In-Reply-To:Subject:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=sgZSed4z9h6PgK06uhPjBLad5vJv6bkv1VifqsSHnf97IO7evOWZH/gwLSUn81d8q h0tw7EjN72+EqMljdZgHz1mA1KAxSym1uyK1NyAjK7+ILICYP3dneVnWEROBLBEDiX ua5m131RrclPXASb+l68SoL9S805+qolqOrMI72k= Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 3C42C3857C61 for ; Sat, 26 Sep 2020 06:16:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3C42C3857C61 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56266) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kM3VN-0006E5-Qj; Sat, 26 Sep 2020 02:16:21 -0400 Received: from [176.228.60.248] (port=1848 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kM3VN-0002G7-AO; Sat, 26 Sep 2020 02:16:21 -0400 Date: Sat, 26 Sep 2020 09:16:35 +0300 Message-Id: <834knlrrjw.fsf@gnu.org> To: Andrew Burgess In-Reply-To: (message from Andrew Burgess on Fri, 25 Sep 2020 23:24:09 +0100) Subject: Re: [PATCHv3 3/3] gdb: Track the current frame for each thread References: X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eli Zaretskii via Gdb-patches Reply-To: Eli Zaretskii Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" > From: Andrew Burgess > Date: Fri, 25 Sep 2020 23:24:09 +0100 > > +set restore-selected-frame [on|off] > +show restore-selected-frame > + This option is off by default. When turned on GDB will record the ^ Comma here, please. > + currently selected frame in each thread. When switching between > + threads GDB will attempt to restore the previously selected frame in ^ And here. > + the thread being switched too. Executing a thread will cause the > + GDB to discard any previously selected frame (GDB will select the "the GDB" sounds awkward; please remove "the". > @item > -the current stack frame summary for that thread > +the current stack frame summary for that thread, this is the inner > +most frame for the thread, see @ref{set restore-selected-frame} to Here, it is best to use @pxref, like this: most frame for the thread (@pxref{set restore-selected-frame}) to > +When switching between threads @value{GDBN} will select the inner most ^ Comma. > +frame in the thread being switched too, see @ref{set > +restore-selected-frame} to change this behaviour. @pxref again. > +If a thread has been running then when it stops the previously ^ ^ Two commas missing. > + add_setshow_boolean_cmd ("restore-selected-frame", > + class_stack, &restore_selected_frame_per_thread, > + _("\ > +Set whether GDB restores the selected frame when switching threads."), _("\ > +Show whether GDB restores the selected frame when switching threads."), _("\ > +When this option is on GDB will record the currently selected frame for\n\ ^ A comma is missing. Documentation parts are OK with those nits fixed. Thanks.