From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128494 invoked by alias); 31 Dec 2017 03:52:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 128469 invoked by uid 89); 31 Dec 2017 03:52:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=BAYES_00,GIT_PATCH_1,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: sesbmg22.ericsson.net Received: from sesbmg22.ericsson.net (HELO sesbmg22.ericsson.net) (193.180.251.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 31 Dec 2017 03:52:25 +0000 Received: from ESESSHC002.ericsson.se (Unknown_Domain [153.88.183.24]) by sesbmg22.ericsson.net (Symantec Mail Security) with SMTP id 82.69.27591.6FE584A5; Sun, 31 Dec 2017 04:52:22 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.24) with Microsoft SMTP Server (TLS) id 14.3.352.0; Sun, 31 Dec 2017 04:52:22 +0100 Received: from [10.0.0.110] (192.222.251.162) by DBXPR07MB319.eurprd07.prod.outlook.com (2a01:111:e400:941d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.386.4; Sun, 31 Dec 2017 03:52:18 +0000 Subject: Re: [PATCH v3.2 2/5] DWARF-5: .debug_names index producer To: Pedro Alves , Jan Kratochvil , Eli Zaretskii CC: , References: <149790572259.20186.14601775821404892582.stgit@host1.jankratochvil.net> <149790574432.20186.16599093068806909362.stgit@host1.jankratochvil.net> <83d19ywuuw.fsf@gnu.org> <20170622183542.GA8552@host1.jankratochvil.net> <83h8z7vnl6.fsf@gnu.org> <20170622200344.GA14233@host1.jankratochvil.net> From: Simon Marchi Message-ID: <83456520-cc06-25a5-de6e-9ae841341b45@ericsson.com> Date: Sun, 31 Dec 2017 03:52:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BN6PR2001CA0045.namprd20.prod.outlook.com (2603:10b6:405:16::31) To DBXPR07MB319.eurprd07.prod.outlook.com (2a01:111:e400:941d::13) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6d5e7b44-6bf5-42cc-9609-08d55001e3cb X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020020)(4534040)(4602075)(4627136)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060);SRVR:DBXPR07MB319; X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB319;3:QQohcWfrt/G4tMWMqdisb8fjdSQ5yThPFbDezBni+qJ0feH4CQu3VpIDfK+WyHBQQKAy1/cnigM/N0ZJpEX5EKT/eBNfYVjfa/qXEwzYKDIHnltkVisJjOtlCuURdvMuyY6WL1i0RAj276wf5uCCImQSSAOar2syKaXenCkaaEViyq9DzAR9T9wz8dfMrDxjPgTtpXuVeLhah5sLVC1bO5L+kYxDQf/54xUjXeygX/ul7ZXfWLcgKaVVmHK/16GU;25:wa9iT/taqkh/VBICxvCOFTCJokg5ZpoAJ+QlsFAM6n3NHgRQmjdJ54RyEhWI8p4vyAgKbQSfo1d5o4YwNieGYYRKxCAHglJNzbS9/mRUT/kHe6/Sx5EMxbIWR1sQlGKL2Yc75oQnKRYTb0XBTKFXTrqJhsIYhZFjYq39gR/ZHRMcsXGVDUlwSb1flRO2TwL09gq/9rHEXOBtJXIP6bXI/kwyHZA2wBSBSNWUCIpJwMtr/Y9kXG/3Yf6MfokxcQo5R6tpRmlnn+nlbLsoE4rnkJ79tOKCqWF8SO9ffU/tQuueKfRlIyGBIyo2599BmKHHTBvZk8J9Ko2z1Bz0OnHhNJKbI9dK1tGjhNP59+nNpDo=;31:kUov4ByaDvYy85ArO9aYxElv4k15pUtUeUaa26AbexRfzaNN5kx48SIF/OZ04s34WTqkALbOypwr5pz+kVuBLcgmpqrPKzhIVFM86PxXdIICxKZH7KUJ96VEv5R/rpALSaZRIWiRlvlB2lAdO05zFRLjGFHosN9j4CV1n5AfxxkymNivzD9+rG1j6sg+CloF0ZjBa4e1IZQnSwJ+Sm6V79v+JMePFJsw3zdMjjLrmPk= X-MS-TrafficTypeDiagnostic: DBXPR07MB319: X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB319;20:D7KKGhqRSWVKJKV1bplHTIuf66gs9SISSgTBDaXjnL+vDbkN06MmMYdF54ucI4sOOUZKDngG3OQf+sb+OxfK4owKD4QmWvWDBLQBOKlghoDEc39KU9NhWQiBUQzgP/1EDYlfdQKeokvPy6agCLPw56RxXF50ejdO1GmjtLlAM5Ki5ESqi4mQzwaNz3nHjF3fxDdn1ITm4IWKvWlONR86+XyrdDvglyTyker9pmsipgnpYIqqARrIysYqK2I7/SJwHvavz3QYPbJ2kI+v/Q/9CDhEFQeVD0OVplGi8yciYu+ZFW/ywNOXZWdqJLiV4mLcFt8QEMhTgRYX3Axvhi55ZLeBxwvM/QvQNfhUoLDMSA6ZGJxt3YVLKGSYvS3My1jE/j7qO+xrGzZNyXCkx2IjYUKDn6VbbYHNcAiBAVMRTiezMJg7fGpFKyvCIhpyMoMaffCZrrvmFS354UvYHZe+95LMt5wytnZmiUCl19ZDMOHYx6+WSxUOGhbpy3P4A8Gu;4:kTvrFL+kgoRM1zv2m3Oyw2jQ/rehTGFSt6i5spZfGHELII74ufD4792qN6VEnombnynBHWxP3Mpqgj7pCaAADK+A5UNo1vi51UPqA8ZBRi1j6TYl9SZrxYHnlHb5KoX1PUAr/zKM3PVlQZgsoC3VEZ/s2uTFNa0rkaTtKIuvxeiCTdT2dMb7Q1IClS0o0b+5dCSnBuswqJ8y0oU1XPSlHp9GVq93+bp9l3UZYFfioZPDGTsysmlBFhQxRTgf8a8khurA0SDfIaHi0+k32lAHGA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(3231023)(944501075)(10201501046)(6041268)(20161123562045)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(6072148)(201708071742011);SRVR:DBXPR07MB319;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:DBXPR07MB319; X-Forefront-PRVS: 0538A71254 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(39860400002)(396003)(346002)(366004)(376002)(39380400002)(189003)(199004)(24454002)(377424004)(52116002)(16576012)(316002)(68736007)(105586002)(106356001)(7736002)(305945005)(83506002)(36756003)(966005)(478600001)(93886005)(16526018)(53546011)(110136005)(31686004)(64126003)(386003)(23746002)(31696002)(97736004)(58126008)(50466002)(76176011)(65806001)(229853002)(8936002)(3846002)(25786009)(8676002)(81166006)(86362001)(53936002)(230700001)(5660300001)(2906002)(65956001)(6666003)(65826007)(2950100002)(6246003)(77096006)(6306002)(4326008)(66066001)(6486002)(6116002)(47776003)(81156014);DIR:OUT;SFP:1101;SCL:1;SRVR:DBXPR07MB319;H:[10.0.0.110];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DBXPR07MB319;23:aZ6XpdbmgvlTClu6IGZzDfOXuJll+tXDOHBVa1?= =?Windows-1252?Q?Hii82N+0F2nrF3kRdLwdSeeduhsCRfYK3QXXxF1lpNZKdFzOpcKnbebu?= =?Windows-1252?Q?tUUPf4+423CPwE9J955wH33LelQ7XguQJygq0PYws1VeOQsz+5RQ56v3?= =?Windows-1252?Q?h+AJCLhXR5o1jdzoLlq5voyLihmgx3p1sfjkfCYFtVARc4LrcQ+XxnAa?= =?Windows-1252?Q?H9euJzFkGo/nQEpW1WCMUs7mCsV35kLOYKbwRJgrMjtiaulHo/H08Kca?= =?Windows-1252?Q?qRMlFmuUioT55QSR400J1nQKNkCYtdxxyX5HXQRWuKZYNoDB4ZCR5LxZ?= =?Windows-1252?Q?mInGLNajXqFRtVHeW7A6LZj7IefWW4mvpm5jsb/Vw3/8nkrc1YDEu/nN?= =?Windows-1252?Q?y7y5QQmCUVWtEXWCtLZCnxlBbq/loLOiJ4vENwApcRJRcp5Y9/WB30Ii?= =?Windows-1252?Q?yHfXmoQWZPGu0eb6wsNwxU5dxrlB33v6Uf3aWYtsvD0vQsfhiIxDehf8?= =?Windows-1252?Q?7wRdhbkFMckzWLoR3L6BK2kFlOW5bOHcB+rP911Mer+tcsWAq4cJsjgw?= =?Windows-1252?Q?101lCpGxduqfY/lExttmlANHQ6itPK/YaziVFEE73nsblsmj1y1zJRHi?= =?Windows-1252?Q?AbLPuIVV2F55IdAwn3fTQMMRHTMRXxa4WzLbDvoQXKo5hUOqFhUbgdJN?= =?Windows-1252?Q?nyGDwmWQIpyivLDLGeyGXQno7ETDjbfmvPGA66CWkb7Zcw8Z57WYklBj?= =?Windows-1252?Q?DaWzHSXXX61bGLoiBWhmn1eUtc9Q18uEg+DH81r2fUjyd5NZHoGBIhKs?= =?Windows-1252?Q?yVYlksavaGzXMQSPPLKhYneCcSlhs3O2zsuVzdPnmC/EU9saiRJMxpup?= =?Windows-1252?Q?b9tC9S5dCxaY7wN+RtCYdet09mo6HDkkaqWEZSdoPCVdSz6KJdaZ3Xle?= =?Windows-1252?Q?BIC7s/I+Zm5VKZVhN3dzkaItw3IiAP6OjESc5qVRqAd5VqBY78oIDMNb?= =?Windows-1252?Q?nf0GoFR1w9Zp2fVMqnJPovY294oRH0sta8kSxo5RDA+/jPoGDsbPXxYX?= =?Windows-1252?Q?qRfYCLLfN5AduQUiev6syamFPtpYBTFsRQdFGvcLrt0651GXGMp68YaX?= =?Windows-1252?Q?ft/S+t6higmTwvuHr9ukAskEccEgav3a3DLDMbeDQ/pmONffNnAd47HJ?= =?Windows-1252?Q?7fzoZaBEAHt9HoNzQMkWO6NRdwMUJpPAEbY7vLp9TgJwytsjkXDV7L3Q?= =?Windows-1252?Q?tUU1mAnYw9JTkE5EDW7xlkwUXoGAapDPcJ2HEirLwU312HTH+hHWckf3?= =?Windows-1252?Q?FMHaXppcREfCAOlJRFNtMcuOHyw9rppCtsLGRRBFNgRqqqj6XfR4uAYa?= =?Windows-1252?Q?hiq9EW+TA0r8YjoNtHQ4XZiCU1f43jyWdEY7WK1tg5q4rWMiA3Sh57Hi?= =?Windows-1252?Q?49XbSLI1xSLg5JAuMYUFWvAVOOsR/YE2XHUqcP73K9+6CXCJlbCvmTeS?= =?Windows-1252?Q?amT08Zzd2WiuIcajp2q3VIF/tF?= X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB319;6:ohJeKalLDMQTzH71M3y9XKdKEOyD7G07P9kZq4scyQarI/VCo2Hfc9HWQJ2wUQGnlzSb+iC87qG9WpXySdE7iZ4Xa/CerTbfrYeKA8cJw8eTD7KdgtuEPcITuzRIcVk/Xfwq9Vh7J19JBajzyk4Tp/qwqhKTgqXagl6MOSzPxF+Z8rPXEbjfoN/MNHP3iKgMLSNzIhfcBYZf8JHcGoP9S6oV8ihjn9JxR6qvm/Ovs9D1mkpTTjnrueqBWXtDhAsq4rMSKw3oduYjsU1NtURpeuo+heDaKEcZx3jOauV/MqZSOVMtzSINOEsbwp2FNTRhZu+RO8rmryqMZxsJnk6/pytzsLYJL6K97BNT3GBcpio=;5:eimUS5XGc8ovBGd2xYVR4GojAHjIUR4lyaCX+LN/lLwxvbai5GPJsuqANofIt+qmUBrvjjji/L96GLUZjgrHuZNRzyYARWZTi7ik7tyztp2W1PG7rRf+D2OmSUdy694j2GgY5YECl7R0yFnIjIoHS+cuup2cQmopFXvL8XjgDJ0=;24:bDtg2NXQrodMzo/ZSM/RpgDJ2CLCt19NFHLrrEMJSMMiCpv4WfAdxiZkQAhsQq+u69bhiqUiA5C9vVfcyVeVVjVGxGUBCI214BIqeUe9E+c=;7:QB8a9Pr94Azj7udj3bdBmmQLmwbiYbhIbQbuvFcwpChF1rnfCGLtO4kI48lsGsh4O76+QG+t1TEnECu91VEauji8TvSpqSSoFDCGCh1vNJ5+CtVxQGz5hbJ43PPKZ46LbWeFs0K/GxIx7OKcOy5zdt2onosfczZryUXyHC2RHz2j7xjYI3zXyYCHOxEvfOV2vnkjc54Pe9yZoANhMbf0MALfKm+9q6zFBxXxeYBOHBeaHerZIdh+UsVcqoMqQKyr SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Dec 2017 03:52:18.1158 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6d5e7b44-6bf5-42cc-9609-08d55001e3cb X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBXPR07MB319 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00531.txt.bz2 On 2017-12-08 06:51 PM, Pedro Alves wrote: >> +static bool >> +check_dwarf64_offsets () >> +{ >> + for (int i = 0; i < dwarf2_per_objfile->n_comp_units; ++i) >> + { >> + const dwarf2_per_cu_data &per_cu (*dwarf2_per_objfile->all_comp_units[i]); >> + >> + if (to_underlying (per_cu.sect_off) >= (static_cast (1) << 32)) >> + return true; >> + } >> + for (int i = 0; i < dwarf2_per_objfile->n_type_units; ++i) >> + { >> + const signatured_type &sigtype (*dwarf2_per_objfile->all_type_units[i]); >> + const dwarf2_per_cu_data &per_cu (sigtype.per_cu); >> + >> + if (to_underlying (per_cu.sect_off) >= (static_cast (1) << 32)) >> + return true; > These look like always return false, since per_cu.sect_off is 32-bit? > I've left it as is, but it doesn't look right to me. Seems like > that makes all the 64-bit support dead as is. Clang indeed complains about this tautology. I made a patch that makes sect_offset 64-bits, if you want to take a look: https://sourceware.org/ml/gdb-patches/2017-12/msg00530.html Simon