From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17892 invoked by alias); 6 Oct 2016 01:10:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17808 invoked by uid 89); 6 Oct 2016 01:10:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=collecting, reader X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 06 Oct 2016 01:10:00 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D763190E5F; Thu, 6 Oct 2016 01:09:58 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9619vV7002405; Wed, 5 Oct 2016 21:09:58 -0400 Subject: Re: [RFA 06/22] Introduce scoped_minimal_symbol_reader To: Tom Tromey , gdb-patches@sourceware.org References: <1474949330-4307-1-git-send-email-tom@tromey.com> <1474949330-4307-7-git-send-email-tom@tromey.com> From: Pedro Alves Message-ID: <8343d689-83b9-646f-6503-d4d19a3d52ba@redhat.com> Date: Thu, 06 Oct 2016 01:10:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1474949330-4307-7-git-send-email-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-10/txt/msg00098.txt.bz2 On 09/27/2016 05:08 AM, Tom Tromey wrote: > -/* Prepare to start collecting minimal symbols. This should be called > - by a symbol reader to initialize the minimal symbol module. > - Currently, minimal symbol table creation is not reentrant; it > - relies on global (static) variables in minsyms.c. */ > +// An RAII-based object that is used to record minimal symbols while > +// they are being read. GCC eschews using // comments, to avoid ending up with a mixbag of styles. Maybe we should follow suit? > +class scoped_minimal_symbol_reader Seems like this is growing to be _the_ reader in following patches? I'm wondering whether the "scoped_" prefix will make sense going forward. Thanks, Pedro Alves