From: Eli Zaretskii <eliz@gnu.org>
To: sami wagiaalla <swagiaal@redhat.com>
Cc: tromey@redhat.com, gdb-patches@sourceware.org
Subject: Re: [patch 2/2] Fix overload resolution of int* vs void*
Date: Fri, 08 Oct 2010 20:46:00 -0000 [thread overview]
Message-ID: <8339sgo1jl.fsf@gnu.org> (raw)
In-Reply-To: <4CAF6B73.5090800@redhat.com>
> Date: Fri, 08 Oct 2010 15:05:23 -0400
> From: sami wagiaalla <swagiaal@redhat.com>
> CC: gdb-patches@sourceware.org
>
> + if (TYPE_NAME (a) && TYPE_NAME (b)
> + && !strcmp (TYPE_NAME (a), TYPE_NAME (b)))
> + return 1;
A minor stylistic nit: can we please use `strcmp (...) == 0' instead
of `!strcmp (...)'? It will produce the same code, but is slightly
more readable.
Thanks.
next prev parent reply other threads:[~2010-10-08 20:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-30 15:24 [patch] " sami wagiaalla
2010-08-30 16:13 ` sami wagiaalla
2010-08-30 20:01 ` Tom Tromey
2010-10-08 18:39 ` [patch 1/2] " sami wagiaalla
2010-10-08 18:54 ` Tom Tromey
2010-10-08 19:35 ` sami wagiaalla
2010-10-08 21:30 ` Tom Tromey
2010-10-08 19:05 ` [patch 2/2] " sami wagiaalla
2010-10-08 20:46 ` Eli Zaretskii [this message]
2010-10-08 21:10 ` sami wagiaalla
2010-10-08 22:54 ` Tom Tromey
2010-10-12 20:01 ` sami wagiaalla
2010-10-12 20:41 ` Tom Tromey
2010-10-13 15:16 ` sami wagiaalla
2010-10-13 15:49 ` Tom Tromey
2010-10-13 18:29 ` sami wagiaalla
2010-10-15 14:46 ` sami wagiaalla
2010-10-15 22:48 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8339sgo1jl.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=swagiaal@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox