Re: [patch] make info regression on --with-system-readline

Eli Zaretskii
2011-01-01T11:26:59Z

> Date: Sat, 1 Jan 2011 12:16:29 +0100
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> Cc: gdb-patches@sourceware.org, tromey@redhat.com
>
> On Sat, 01 Jan 2011 11:02:02 +0100, Eli Zaretskii wrote:
> > "make distclean" _should_ be reliable, since its main raison d'etre is
> > to allow a clean build after re-configuration. So maybe we should fix
> > that instead (e.g., it doesn't currently remove GDBvn.texi).
>
> If "make distclean" should clean it then it also should not be distributed.

Yes, and I already agreed to that, albeit without saying that
explicitly ;-)

> And we are back at the point GDB currently cannot do easily `make dist'.

What is "make dist"? I see no such target in Makefile.in. Do I need
more coffee? ;-)

> > > But even if you do just first configure it is now broken in GDB as the files
> > > get inappropriately distributed.
> >
> > Sorry, I don't follow. Can you describe the scenario in more detail?
>
> rm -rf gdb-7.2.50.20101231; tar xjf gdb-7.2.50.20101231.tar.bz2; cd gdb-7.2.50.20101231; patch -p1 <THE-FIRST-PATCH-POSTED; mkdir b; cd b; CFLAGS= ../configure --with-system-readline; make; rm gdb/doc/gdb.info; make -C gdb/doc gdb.info
> ../../../gdb/doc/gdb.texinfo:30521: @include `rluser.texi': No such file or directory.
> ../../../gdb/doc/gdb.texinfo:30521: @include `inc-hist.texinfo': No such file or directory.
>
> Both exist:
> ./gdb-7.2.50.20101231/gdb/doc/GDBvn.texi
> ./gdb-7.2.50.20101231/b/gdb/doc/GDBvn.texi

Okay, but what I really meant is what's that part about "the files get
inappropriately distributed"? I guess you just meant to say the same
thing IOW, namely that a wrong GDBvn.texi gets picked up by makeinfo,
is that right?

> > I prefer to do with GDBvn.texi what many projects do with config.h:
> > regenerate it on a temporary file, then use move-if-change to move it
> > into the real file. Would that resolve your problem? It certainly
> > resolves mine.
>
> OK, going to post it.

Thanks.