From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13880 invoked by alias); 1 Jan 2011 09:23:28 -0000 Received: (qmail 13871 invoked by uid 22791); 1 Jan 2011 09:23:27 -0000 X-SWARE-Spam-Status: No, hits=1.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_JMF_BL,SPF_SOFTFAIL,TW_XJ X-Spam-Check-By: sourceware.org Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 01 Jan 2011 09:23:22 +0000 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LEC00G007CSNH00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Sat, 01 Jan 2011 11:23:13 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.124.219.104]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LEC00FJT7ENTKC0@a-mtaout20.012.net.il>; Sat, 01 Jan 2011 11:23:12 +0200 (IST) Date: Sat, 01 Jan 2011 09:23:00 -0000 From: Eli Zaretskii Subject: Re: [patch] make info regression on --with-system-readline In-reply-to: <20110101011319.GA27139@host1.dyn.jankratochvil.net> To: Jan Kratochvil Cc: gdb-patches@sourceware.org, tromey@redhat.com Reply-to: Eli Zaretskii Message-id: <8339pdq8la.fsf@gnu.org> References: <20110101011319.GA27139@host1.dyn.jankratochvil.net> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00004.txt.bz2 > Date: Sat, 1 Jan 2011 02:13:24 +0100 > From: Jan Kratochvil > Cc: Tom Tromey > > since: > [2/2] RFA: --with-system-readline -vs- gdb.texinfo > http://sourceware.org/ml/gdb-patches/2010-11/msg00270.html > > $ rm -rf gdb-7.2.50.20101231; tar xjf gdb-7.2.50.20101231.tar.bz2; cd gdb-7.2.50.20101231; CFLAGS= ./configure --with-system-readline; make; rm gdb/doc/gdb.info; make -C gdb/doc gdb.info > -> > [...] > makeinfo -I ./../mi -I . \ > -o gdb.info ./gdb.texinfo > ./gdb.texinfo:30521: @include `rluser.texi': No such file or directory. > ./gdb.texinfo:30521: @include `inc-hist.texinfo': No such file or directory. > [...] > Fedora 14 x86_64 > > It is because GDBvn.texi has started to depend on the configure options. Aren't you supposed to "make distclean" whenever you reconfigure? That's what I do in every project, because I don't trust the Makefiles to DTRT in such case. E.g., what about all the *.o files you didn't remove? > -GDBvn.texi : ${gdbdir}/version.in > +GDBvn.texi : ${gdbdir}/version.in Makefile Thanks. However, I don't like rules that depend of Makefiles, because they tend to be re-run too much for no good reason. Note that this will re-make the docs each time you reconfigure, even if you didn't change the configuration. But if I'm the only one who dislikes this, I won't object to the change. > Another issue is that GDBvn.texi and gdb-cfg.texi should not be distributed. How can we not distribute them when gdb.texinfo @include's them, and needs that for setting some of the variables the manual uses? If we don't distribute them, end users will be unable to rebuild the manual. What am I missing here?