Re: [RFA] Environment variables passed to inferior by MinGW build (PR 10989)

Joel Brobecker
2011-09-26T17:15:37Z

> >Ping! Ping! (2 weeks)
>
> Seems uncontroversial to me (the previous discussion being about
> entirely different issues). Let's put it in!

And I think that 2 weeks without comment from the area maintainer
is reasonable delay for a Global Maintainer to approve or
self-approve... If it turns out the area maintainer was away
during that time, and finds some problems, we can always fix or
revert.

> >>>2011-09-11 Eli Zaretskii<eliz@gnu.org>
> >>>
> >>> * windows-nat.c (env_sort) [!__CYGWIN__]: Function restored from
> >>> before the change on 2006-12-09.
> >>> (windows_create_inferior) [!__CYGWIN__]: Restore code that
> >>> generates the environment block for CreateProcessA, modulo the
> >>> Cygwin-specific parts that are not needed here.

Just a few comments:

> >>>+#ifndef __CYGWIN__
> >>>+/* Function called by qsort to sort environment strings. */
> >>>+static int

Empty line after the function description (and before the declaration).

> >>>+env_sort (const void *a, const void *b)

Can we rename it to something like `env_cmp'. The use of `sort' makes
me think that the contents of `a' and `b' are going to be swapped if
b < a...

(this is a bit of a nitpick, so feel free to ignore)

> >>>+ for (envlen = 0, i = 0; in_env[i]&& *in_env[i]; i++)
^^^ formatting of the `&&' ?

--
Joel