From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22012 invoked by alias); 7 Dec 2012 15:16:14 -0000 Received: (qmail 22001 invoked by uid 22791); 7 Dec 2012 15:16:13 -0000 X-SWARE-Spam-Status: No, hits=-4.5 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 07 Dec 2012 15:16:07 +0000 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MEO007002BIZH00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Fri, 07 Dec 2012 17:16:05 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MEO007DZ2ESZ710@a-mtaout20.012.net.il>; Fri, 07 Dec 2012 17:16:05 +0200 (IST) Date: Fri, 07 Dec 2012 15:16:00 -0000 From: Eli Zaretskii Subject: Re: [patch v5 02/12] cli, btrace: add btrace cli In-reply-to: <1354876644-25749-3-git-send-email-markus.t.metzger@intel.com> To: markus.t.metzger@intel.com Cc: gdb-patches@sourceware.org, jan.kratochvil@redhat.com, palves@redhat.com, tromey@redhat.com, kettenis@gnu.org Reply-to: Eli Zaretskii Message-id: <8338zhopuk.fsf@gnu.org> References: <1354876644-25749-1-git-send-email-markus.t.metzger@intel.com> <1354876644-25749-3-git-send-email-markus.t.metzger@intel.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00176.txt.bz2 > From: markus.t.metzger@intel.com > Cc: markus.t.metzger@gmail.com, jan.kratochvil@redhat.com, palves@redhat.com, tromey@redhat.com, kettenis@gnu.org, Markus Metzger > Date: Fri, 7 Dec 2012 11:37:14 +0100 > > From: Markus Metzger > > Add branch trace commands: Thanks. This will be documented at some point, yes? > + add_cmd ("list", class_btrace, cmd_btrace_list, _("\ > +List branch trace blocks.\n\n\ > +Prints a list of all blocks for which branch trace is available.\n\ "Print", not "prints", to be compatible with "List". > +With a /a modifier, addresses are included.\n\ > +With a /f modifier, the function name is included (if available).\n\ It is better to use active tense, not passive tense: With a /a modifier, include addresses. With a /f modifier, include function names (if available). > +With a /l modifier, source lines are include (if available).\n\ ^^^^^^^ A typo. > +With a /t modifier, prints the total number of trace blocks and stops.\n\ ^^^^^^ "print" > +Without any modifier, behaves as if /fl were specified.\n\n\ By default, include function names and source lines. And I have a question: how to turn off all the optional print-outs? Is there a /no-f modifier or something? > +Without arguments, the full list of blocks is listed.\n\ > +With a range ([-]) argument, lists all blocks in that range.\n"), Again, use active tense, and "list" instead of "lists". Thanks.