From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30937 invoked by alias); 30 Jan 2013 17:15:52 -0000 Received: (qmail 30923 invoked by uid 22791); 30 Jan 2013 17:15:49 -0000 X-SWARE-Spam-Status: No, hits=-4.5 required=5.0 tests=AWL,BAYES_00,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,RCVD_IN_HOSTKARMA_YE,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 30 Jan 2013 17:15:43 +0000 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MHG000007VG9S00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Wed, 30 Jan 2013 19:15:20 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MHG00MUZ7XJOFH0@a-mtaout20.012.net.il>; Wed, 30 Jan 2013 19:15:20 +0200 (IST) Date: Wed, 30 Jan 2013 17:15:00 -0000 From: Eli Zaretskii Subject: Re: [patchv3 12/11] New options {relative,basename}-with-system-absolute In-reply-to: <20130130074820.GA15998@host2.jankratochvil.net> To: Jan Kratochvil Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <8338xiiodg.fsf@gnu.org> References: <20130129221019.GA27463@host2.jankratochvil.net> <20130130074820.GA15998@host2.jankratochvil.net> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00718.txt.bz2 > Date: Wed, 30 Jan 2013 08:48:20 +0100 > From: Jan Kratochvil > > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -115,7 +115,8 @@ show print type typedefs > Control whether typedef definitions are displayed by "ptype". > The default is to show them. > > -set filename-display basename|relative|absolute > +set filename-display basename|relative|absolute|relative-with-system-absolute > + |basename-with-system-absolute Can't say I like these too-old names. Otherwise, OK for this part. > +@item set filename-display relative-with-system-absolute > +Determine whether a source filename comes from file having separate debug > +information file. In such case display the source filename as absolute one. > +Otherwise display it relative to the compilation directory. The option controls how file names are displayed, so starting its description with "Determine ..." is not the best way. That first sentence got me puzzled for a few seconds. I suggest something like this: Display as absolute those source file names that come from files with separate debug info, and all the other source file names as relative to their compilation directory. > +@item set filename-display basename-with-system-absolute > +Determine whether a source filename comes from file having separate debug > +information file. In such case display the source filename as absolute one. > +Otherwise display only basename of the filename. Similarly here: start with "Display ..." as this what the option controls. > +Files having separate debug information file are expected to come from system > +shared libraries. This repetition is unnecessary. OK with these changes. Thanks.