From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-111656-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 27377 invoked by alias); 9 Apr 2014 16:37:04 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 27367 invoked by uid 89); 9 Apr 2014 16:37:04 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_40,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout29.012.net.il
Received: from mtaout29.012.net.il (HELO mtaout29.012.net.il) (80.179.55.185) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Apr 2014 16:37:02 +0000
Received: from conversion-daemon.mtaout29.012.net.il by mtaout29.012.net.il (HyperSendmail v2007.08) id <0N3R00600VB51E00@mtaout29.012.net.il> for gdb-patches@sourceware.org; Wed, 09 Apr 2014 19:39:11 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout29.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N3R00PHGVLB1270@mtaout29.012.net.il>; Wed, 09 Apr 2014 19:39:11 +0300 (IDT)
Date: Wed, 09 Apr 2014 16:37:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH 5/8] Remove Guile GDB object property mechanism
In-reply-to: <1397059725-18066-9-git-send-email-wingo@igalia.com>
To: Andy Wingo <wingo@igalia.com>
Cc: gdb-patches@sourceware.org, wingo@igalia.com
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <8338hm5ujb.fsf@gnu.org>
References: <1397059725-18066-1-git-send-email-wingo@igalia.com> <1397059725-18066-9-git-send-email-wingo@igalia.com>
X-IsSubscribed: yes
X-SW-Source: 2014-04/txt/msg00146.txt.bz2

> From: Andy Wingo <wingo@igalia.com>
> Cc: Andy Wingo <wingo@igalia.com>
> Date: Wed,  9 Apr 2014 18:08:37 +0200
> 
> * gdb/guile/guile-internal.h: Remove scm_gsmob / GDB_SMOB_HEAD base
>   type; it only served as something to which object properties could be
>   attached: a use case already served by Guile's own object properties.
>   (gdbscm_init_gsmob, gdbscm_mark_gsmob, gdbscm_mark_chained_gsmob)
>   (gdbscm_mark_eqable_gsmob): Remove these now-unneeded functions.
> 
> * gdb/guile/scm-gsmob.c (gdbscm_init_gsmob, gdbscm_mark_gsmob)
>   (gdbscm_mark_chained_gsmob, gdbscm_mark_eqable_gsmob): Remove.
>   (gdbscm_gsmob_property, gdbscm_set_gsmob_property_x)
>   (gdbscm_gsmob_has_property_p, add_property_name)
>   (gdbscm_gsmob_properties): Remove these public interfaces, and remove
>   them from gsmob_functions.
> 
> * gdb/guile/scm-arch.c:
> * gdb/guile/scm-block.c:
> * gdb/guile/scm-breakpoint.c:
> * gdb/guile/scm-exception.c:
> * gdb/guile/scm-frame.c:
> * gdb/guile/scm-iterator.c:
> * gdb/guile/scm-lazy-string.c:
> * gdb/guile/scm-objfile.c:
> * gdb/guile/scm-pretty-print.c:
> * gdb/guile/scm-symbol.c:
> * gdb/guile/scm-symtab.c:
> * gdb/guile/scm-type.c:
> * gdb/guile/scm-value.c: Adapt to not include a gdb_gsmob base member,
>   for basic gsmobs, and to not call init/mark functions.
> 
> * gdb/doc/guile.texi (GDB Scheme Data Types): Update.

OK for the documentation part.