From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 435 invoked by alias); 25 Jul 2015 17:30:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 364 invoked by uid 89); 25 Jul 2015 17:30:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mtaout21.012.net.il Received: from mtaout21.012.net.il (HELO mtaout21.012.net.il) (80.179.55.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 25 Jul 2015 17:30:48 +0000 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0NS200F000KIDL00@a-mtaout21.012.net.il> for gdb-patches@sourceware.org; Sat, 25 Jul 2015 20:30:45 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NS200FCT0N9A390@a-mtaout21.012.net.il>; Sat, 25 Jul 2015 20:30:45 +0300 (IDT) Date: Sat, 25 Jul 2015 17:30:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH] Make sure GDB uses a valid shell when starting the inferior and to perform the "shell" command In-reply-to: <87k2to41bj.fsf@redhat.com> To: Sergio Durigan Junior Cc: simon.marchi@ericsson.com, gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83380c16wo.fsf@gnu.org> References: <1437761993-18758-1-git-send-email-sergiodj@redhat.com> <55B2850D.6030306@ericsson.com> <87k2tp5q3g.fsf@redhat.com> <838ua52wmp.fsf@gnu.org> <87fv4d5p8l.fsf@redhat.com> <837fpp2uz5.fsf@gnu.org> <55B29B84.5000707@ericsson.com> <8361583e6v.fsf@gnu.org> <87oaj042uz.fsf@redhat.com> <834mks196a.fsf@gnu.org> <87k2to41bj.fsf@redhat.com> X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00752.txt.bz2 > From: Sergio Durigan Junior > Cc: simon.marchi@ericsson.com, gdb-patches@sourceware.org > Date: Sat, 25 Jul 2015 13:03:12 -0400 > > The new section says: > > @node Valid Shell > @subsection Valid Shell > > @value{GDBN} considers a @emph{valid shell} a file that: > > @enumerate > @item > Exists and can be executed by the user. > > @item > Is not the @file{/sbin/nologin} (or @file{/usr/sbin/nologin}) program. > > @item > Is not the @file{/bin/false} program. > @end enumerate > > If any of those conditions are not met, the specified shell is not > used by @value{GDBN}. > > I do not see any difference from what I said above, but if you think > this text can be improved, or that this text is not needed at all, then > by all means feel free to ask this. The use of "valid" seems to imply much broader goals. Your description seems to say that "pseudo-shells used to disable logins" is a better (though longer) terminology. Also, I suggest to say "such as the following", so as not to imply that this is necessarily an exhaustive list. Finally, is it really OK to lump here the "cannot be executed by the user" case? Maybe we should error out in that case.