From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90057 invoked by alias); 5 Feb 2016 14:53:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90044 invoked by uid 89); 5 Feb 2016 14:53:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:59999, crystal, HX-Received-From:134, HX-Received-From:4830 X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 05 Feb 2016 14:53:09 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aRhkt-00026a-1W for gdb-patches@sourceware.org; Fri, 05 Feb 2016 09:53:07 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59999) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRhks-00026O-S7; Fri, 05 Feb 2016 09:53:02 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1705 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aRhkr-000136-Dr; Fri, 05 Feb 2016 09:53:02 -0500 Date: Fri, 05 Feb 2016 14:53:00 -0000 Message-Id: <8337t7us3k.fsf@gnu.org> From: Eli Zaretskii To: Simon Marchi CC: gdb-patches@sourceware.org In-reply-to: <1454681876-17628-1-git-send-email-simon.marchi@polymtl.ca> (message from Simon Marchi on Fri, 5 Feb 2016 09:17:56 -0500) Subject: Re: [PATCH] Add printf format specifier for printing enumerator Reply-to: Eli Zaretskii References: <1454681876-17628-1-git-send-email-simon.marchi@polymtl.ca> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00149.txt.bz2 > From: Simon Marchi > Cc: Simon Marchi > Date: Fri, 5 Feb 2016 09:17:56 -0500 > > This patch adds a format specifier to gdb's printf command, to print the > enumerator (the text label) of an enum value. It's currently possible > to display that value using the print command, but not as part of a > formatted string. > > For example, assuming we have the following enum definition: > > enum NodeType { > ... > NODE_INTEGER, > ... > }; > > enum NodeType node = NODE_INTEGER; > > we can display it this way: > > (gdb) printf "Visiting node of type %q\n", node > Visiting node of type NODE_INTEGER > > All the letters of "enum" are already used as format specifiers. What about upper-case letters? > +@code{printf} supports the @samp{q} conversion letter to print the textual > +label (enumerator) of a C enumeration value. This sentence will look awkward because it starts with a lower-case letter. How about starting with "Also, "? I think an example here will be good, as the text does not make it crystal clear what will be printed. Other than that, the documentation parts look good to me, thanks.