From: Eli Zaretskii <eliz@gnu.org>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix djgpp gdb build
Date: Thu, 21 Jul 2016 14:36:00 -0000 [thread overview]
Message-ID: <8337n3ys6c.fsf@gnu.org> (raw)
In-Reply-To: <1469103990-8482-1-git-send-email-palves@redhat.com> (message from Pedro Alves on Thu, 21 Jul 2016 13:26:30 +0100)
> From: Pedro Alves <palves@redhat.com>
> Date: Thu, 21 Jul 2016 13:26:30 +0100
>
> - A few missing casts required by C++, resulting in:
>
> ../../src/gdb/ser-go32.c:795:21: error: invalid conversion from 'const void*' to 'const char*' [-fpermissive]
>
> etc.
>
> - dos_noop has an incompatible prototype with struct serial_ops's
> setparity, resulting in:
>
> ../../src/gdb/ser-go32.c:874:1: error: invalid conversion from 'int (*)(serial*)' to 'int (*)(serial*, int)' [-fpermissive]
>
> (I thought of calling the ser-base.c default methods, but djgpp
> doesn't include ser-base.c in the build.)
>
> gdb/ChangeLog:
> 2016-07-21 Pedro Alves <palves@redhat.com>
>
> * go32-nat.c (go32_create_inferior): Add cast.
> * ser-go32.c (dos_noop): Delete.
> (dos_flush_output, dos_setparity, dos_drain_output): New
> functions.
> (dos_write): Add cast.
> (dos_ops): Use dos_flush_output, dos_setparity and
> dos_drain_output.
> * top.c (do_chdir_cleanup): Add cast.
OK. Thanks for taking care of this port.
prev parent reply other threads:[~2016-07-21 14:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-21 12:26 Pedro Alves
2016-07-21 14:36 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8337n3ys6c.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox