From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30585 invoked by alias); 26 Jan 2017 19:36:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30569 invoked by uid 89); 26 Jan 2017 19:36:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=H*r:134, H*r:sk:RSA_AES X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 26 Jan 2017 19:36:04 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cWppu-00083J-O1 for gdb-patches@sourceware.org; Thu, 26 Jan 2017 14:36:01 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:52609) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cWppu-00083F-KS; Thu, 26 Jan 2017 14:35:58 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3729 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cWppt-0004Su-DU; Thu, 26 Jan 2017 14:35:58 -0500 Date: Thu, 26 Jan 2017 19:36:00 -0000 Message-Id: <8337g53984.fsf@gnu.org> From: Eli Zaretskii To: Luis Machado CC: gdb-patches@sourceware.org In-reply-to: <1485451129-16439-2-git-send-email-lgustavo@codesourcery.com> (message from Luis Machado on Thu, 26 Jan 2017 11:18:49 -0600) Subject: Re: [PATCH 2/2] [BZ 21005] Add support for Intel 64 rdrand and rdseed record/replay Reply-to: Eli Zaretskii References: <1485451129-16439-1-git-send-email-lgustavo@codesourcery.com> <1485451129-16439-2-git-send-email-lgustavo@codesourcery.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2017-01/txt/msg00602.txt.bz2 > From: Luis Machado > Date: Thu, 26 Jan 2017 11:18:49 -0600 > > The following patch addresses BZ 21005, which is gdb failing to > recognize an rdrand instruction. > > It enables support for both rdrand and rdseed and handles extended register > addressing (R8~R15) for 16-bit, 32-bit and 64-bit. > > I tested this by hand with quite a few lines of inline asm. I thought we > had arch-specific tests in testsuite/, but it looks like we don't exercise > every little instruction with record/replay, so no testcase. Let me know > if one is required. > > Regression-tested on Ubuntu 16.04 x86-64. > > Testsuite results are as follows: > > === gdb Summary === > > # of expected passes 159 > > OK? > > gdb/ChangeLog > > 2017-01-26 Luis Machado > > * NEWS: Mention support for record/replay of Intel 64 rdrand and > rdseed instructions. > i386-tdep.c (i386_process_record): Handle Intel 64 rdrand and rseed. OK for the NEWS part.