From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 127081 invoked by alias); 25 May 2017 18:13:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 127056 invoked by uid 89); 25 May 2017 18:13:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 25 May 2017 18:12:57 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dDxFn-0006Lq-NP for gdb-patches@sourceware.org; Thu, 25 May 2017 14:12:58 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46884) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dDxFn-0006Lm-Jz; Thu, 25 May 2017 14:12:55 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3196 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dDxFm-00030R-7H; Thu, 25 May 2017 14:12:55 -0400 Date: Thu, 25 May 2017 18:13:00 -0000 Message-Id: <8337bsls9v.fsf@gnu.org> From: Eli Zaretskii To: Peter Linss CC: gdb-patches@sourceware.org In-reply-to: <33B79B83-FB3D-4385-8B13-3BC10F8C58D1@elemental.software> (message from Peter Linss on Thu, 25 May 2017 10:51:26 -0700) Subject: Re: [PATCH] Fix usage of to_string() for pretty-printers with children Reply-to: Eli Zaretskii References: <83shjtkmo8.fsf@gnu.org> <33B79B83-FB3D-4385-8B13-3BC10F8C58D1@elemental.software> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00551.txt.bz2 > From: Peter Linss > Date: Thu, 25 May 2017 10:51:26 -0700 > Cc: gdb-patches@sourceware.org > > > Please add back the comma removed here. > > > > The documentation part is approved with this gotcha fixed. > > > > Thanks. > > Revised patch with comma restored (not sure if you want a new email thread for small patch revisions like this): Thanks, this is OK. For the future, when I say "approved with that fixed", there's no need to post the corrected patch, just be sure to correct it before pushing.