Re: [PATCH 1/4] Implement 'set honor-dontdump-flag' command

Sergio Lopez
2017-11-29T10:59:40Z

On Tue, Nov 28, 2017 at 4:42 PM, Sergio Durigan Junior
<sergiodj@redhat.com> wrote:
> On Tuesday, November 28 2017, Sergio Lopez wrote:
>> diff --git a/gdb/linux-tdep.c b/gdb/linux-tdep.c
>> index 24237b8d39..5f4a1cdad1 100644
>> --- a/gdb/linux-tdep.c
>> +++ b/gdb/linux-tdep.c
>> @@ -93,6 +93,11 @@ struct smaps_vmflags
>>
>> static int use_coredump_filter = 1;
>>
>> +/* Whether to honor the VM_DONTDUMP flag in /proc/PID/smaps when
>> + generating a corefile. */
>> +
>> +static int honor_dontdump_flag = 1;
>
> No empty line between command and definition of variable.

This is the only suggestion that I haven't applied because it would
break the coding style of the previous lines:

gdb/linux-tdep.c:
89 };
90
91 /* Whether to take the /proc/PID/coredump_filter into account when
92 generating a corefile. */
93
94 static int use_coredump_filter = 1;
95
96 /* Whether the value of smaps_vmflags->exclude_coredump should be
97 ignored, including mappings marked with the VM_DONTDUMP flag in
98 the dump. */
99
100 static int dump_excluded_mappings = 0;
101
102 /* This enum represents the signals' numbers on a generic architecture

--
Sergio