From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 108533 invoked by alias); 28 Feb 2019 19:45:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 108505 invoked by uid 89); 28 Feb 2019 19:45:02 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,KAM_NUMSUBJECT,SPF_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:2181 X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 28 Feb 2019 19:45:00 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45758) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gzRby-0005bQ-9d; Thu, 28 Feb 2019 14:44:55 -0500 Received: from [176.228.60.248] (port=3549 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gzRbx-0001Jv-Mn; Thu, 28 Feb 2019 14:44:54 -0500 Date: Thu, 28 Feb 2019 19:45:00 -0000 Message-Id: <8336o7k89n.fsf@gnu.org> From: Eli Zaretskii To: Sergio Durigan Junior CC: brobecker@adacore.com, gdb-patches@sourceware.org In-reply-to: <87pnrbivz4.fsf@redhat.com> (message from Sergio Durigan Junior on Thu, 28 Feb 2019 13:55:27 -0500) Subject: Re: MinGW build of GDB 8.2.90 References: <20190227055112.4A5E782D7B@joel.gnat.com> <837edjkbp4.fsf@gnu.org> <87pnrbivz4.fsf@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-02/txt/msg00574.txt.bz2 > From: Sergio Durigan Junior > Cc: Joel Brobecker , gdb-patches@sourceware.org > Date: Thu, 28 Feb 2019 13:55:27 -0500 > > However, and more importantly, I remember testing the whole patch by > compiling it using a mingw32 compiler on Fedora, and it was working > correctly. In fact, we even have a mingw32 builder on our BuildBot > (running on Fedora), and it is still compiling GDB without problems: > > https://gdb-build.sergiodj.net/builders/Fedora-x86_64-w64-mingw32 > > So apparently this error is only triggered when you use mingw on > Windows...? I don't know. No, the problem is that there are two flavors of MinGW, and I used the other one. > As I said, I don't use Windows and don't understand the system, but if > these changes fix the problem for you, I'd say they're justified and > should be pushed (even though I don't understand the "if > _WIN32_WINNT..." part). For the record, the _WIN32_WINNT part is because mingw.org's MinGW by default defines _WIN32_WINNT to target older versions of Windows, which don't support getaddrinfo, and the Windows API headers then mask the prototypes of those functions. > > Note that one other side effect of the IPv6 support additions is that > > on MS-Windows GDB will no longer run on versions older than XP, I > > guess this is something that should be mentioned in NEWS? > > I confess I did not know that. If that's the case, then we should > indeed notify the users via the NEWS file, IMO. OK, will do. > > CXX xml-syscall.o > > xml-syscall.c: In function 'bool xml_list_syscalls_by_group(gdbarch*, const char*, std::vector*)': > > xml-syscall.c:475:14: warning: types may not be defined in a for-range-declaration > > for (const struct syscall_desc *sysdesc : groupdesc->syscalls) > > ^~~~~~ > > > > I solved the latter by removing "struct" from the declaration. This > > is with GCC 6.3.0; is that a GCC bug? is removing "struct" the right > > solution? > > Yeah, this is the right thing to do. I remember having to do this a few > times, and seeing other patches doing the same. OK, will do that as well. Thanks for the feedback.