From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-154645-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 46681 invoked by alias); 16 Mar 2019 12:17:00 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 46651 invoked by uid 89); 16 Mar 2019 12:17:00 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-8.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy=
X-HELO: eggs.gnu.org
Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 16 Mar 2019 12:16:59 +0000
Received: from fencepost.gnu.org ([2001:470:142:3::e]:58789)	by eggs.gnu.org with esmtp (Exim 4.71)	(envelope-from <eliz@gnu.org>)	id 1h58FE-00088e-0R; Sat, 16 Mar 2019 08:16:56 -0400
Received: from [176.228.60.248] (port=4044 helo=home-c4e4a596f7)	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)	(Exim 4.82)	(envelope-from <eliz@gnu.org>)	id 1h58FD-0003ex-Fg; Sat, 16 Mar 2019 08:16:55 -0400
Date: Sat, 16 Mar 2019 12:17:00 -0000
Message-Id: <8336nnypxz.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Pedro Alves <palves@redhat.com>
CC: tromey@adacore.com, gdb-patches@sourceware.org
In-reply-to: <33f140c3-f0b1-6750-2142-5365bb5466e9@redhat.com> (message from	Pedro Alves on Fri, 15 Mar 2019 12:43:21 +0000)
Subject: Re: Avoid overwriting the TUI source window frame (Re: [RFC 8.3 0/3] Some style fixes)
References: <20190308210433.32683-1-tromey@adacore.com> <83pnr08tc8.fsf@gnu.org> <83zhq26fcw.fsf@gnu.org> <874l899nh3.fsf@tromey.com> <8336ns3uv4.fsf@gnu.org> <33f140c3-f0b1-6750-2142-5365bb5466e9@redhat.com>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-IsSubscribed: yes
X-SW-Source: 2019-03/txt/msg00333.txt.bz2

> Cc: gdb-patches@sourceware.org
> From: Pedro Alves <palves@redhat.com>
> Date: Fri, 15 Mar 2019 12:43:21 +0000
> 
> On 03/12/2019 04:44 PM, Eli Zaretskii wrote:
> > 2. The fix for avoiding to overwrite the source window frame is
> > simple: revert 4a3045920.  I don't really understand why that change
> > was made: AFAIU, wclrtoeol clears to the end of the window line, and
> > cannot be told to clear only part of the line.
> > 
> > --- gdb/tui/tui-winsource.c~4	2019-02-27 06:51:50.000000000 +0200
> > +++ gdb/tui/tui-winsource.c	2019-03-12 10:57:02.052875200 +0200
> > @@ -285,7 +285,12 @@ tui_show_source_line (struct tui_win_inf
> >      wattroff (win_info->generic.handle, A_STANDOUT);
> >  
> >    /* Clear to end of line but stop before the border.  */
> > -  wclrtoeol (win_info->generic.handle);
> > +  int x = getcurx (win_info->generic.handle);
> > +  while (x + 1 < win_info->generic.width)
> > +    {
> > +      waddch (win_info->generic.handle, ' ');
> > +      x = getcurx (win_info->generic.handle);
> > +    }
> >  }
> >  
> 
> Makes sense to me.  I confirm this fixes it for me too.

Thanks, pushed to both branches.