Re: [PATCH][PR server/24377] Fix mixing English and system default languages in error messages on Windows

Eli Zaretskii
2019-03-23T13:11:27Z

> From: Ð’Ð»Ð°Ð´Ð¸Ð¼Ð¸Ñ€ ÐœÐ°Ñ€Ñ‚ÑŒÑÐ½Ð¾Ð² <vilgeforce@gmail.com>
> Date: Sat, 23 Mar 2019 14:59:05 +0300
>
> The fourth argument of FormatMessage() in strwinerror() in file
> win32-low.c is set to zero. Thus, Windows could use system default
> locale to translate error codes to error message. At the same time,
> gdbserver have hardcoded English error messages ("Error creating
> process..." for example). As a result, server could display error
> messages with mixed languages.
>
> I made a patch to use en_US locale in FormatMessage, so all error
> messages will be in English.

Thanks, but isn't this a step backward? Would it make sense to have
the hard-coded messages be translated instead? Or is that impossible
for some reason?