From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26169 invoked by alias); 4 Jan 2020 18:57:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25913 invoked by uid 89); 4 Jan 2020 18:57:17 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=scrolled, well-known, wellknown X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 04 Jan 2020 18:57:15 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54554) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1inobq-0006Mo-1S; Sat, 04 Jan 2020 13:57:14 -0500 Received: from [176.228.60.248] (port=3340 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1inobn-00027q-Lt; Sat, 04 Jan 2020 13:57:13 -0500 Date: Sat, 04 Jan 2020 18:57:00 -0000 Message-Id: <8336cvgid8.fsf@gnu.org> From: Eli Zaretskii To: Tom Tromey CC: gdb-patches@sourceware.org In-reply-to: <20200104183410.17114-21-tom@tromey.com> (message from Tom Tromey on Sat, 4 Jan 2020 11:34:06 -0700) Subject: Re: [PATCH 20/24] Allow TUI windows in Python References: <20200104183410.17114-1-tom@tromey.com> <20200104183410.17114-21-tom@tromey.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2020-01/txt/msg00082.txt.bz2 > From: Tom Tromey > Cc: Tom Tromey > Date: Sat, 4 Jan 2020 11:34:06 -0700 > > 2020-01-04 Tom Tromey > > * NEWS: Add entry for gdb.register_window_type. > * tui/tui-layout.h (window_factory): New typedef. > (tui_register_window): Declare. > * tui/tui-layout.c (saved_tui_windows): New global. > (tui_apply_current_layout): Use it. > (tui_register_window): New function. > * python/python.c (do_start_initialization): Call > gdbpy_initialize_tui. > (python_GdbMethods): Add "register_window_type" function. > * python/python-internal.h (gdbpy_register_tui_window) > (gdbpy_initialize_tui): Declare. > * python/py-tui.c: New file. > * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-tui.c. > > gdb/doc/ChangeLog > 2020-01-04 Tom Tromey > > * python.texi (Python API): Add menu item. > (TUI Windows In Python): New node. > > gdb/testsuite/ChangeLog > 2020-01-04 Tom Tromey > > * gdb.python/tui-window.exp: New file. > * gdb.python/tui-window.py: New file. OK for the documentation parts, with two comments. > +terminal escape styling sequences; @value{GDBN} will convert translate > +these as appropriate for the terminal. ^^^^^^^^^^^^^^^^^ One of these two words should be removed. > +@defun Window.hscroll (@var{num}) > +This is a request to scroll the window horizontally. @var{num} is the > +amount by which to scroll, with negative numbers meaning to scroll > +right. > +@end defun > + > +@defun Window.vscroll (@var{num}) > +This is a request to scroll the window vertically. @var{num} is the > +amount by which to scroll, with negative numbers meaning to scroll > +backward. There's a well-known source of confusion with describing scrolling direction: does it refer to scrolling of the text in the window (i.e. the window is considered to be fixed and the text to be scrolled) or the other way around? The confusion stems from the fact that we say "scroll the window", but what is actually scrolled is the text. Can we please make it crystal clear here what will move right and backward here? Thanks.