From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21973 invoked by alias); 1 May 2009 09:26:56 -0000 Received: (qmail 21962 invoked by uid 22791); 1 May 2009 09:26:54 -0000 X-SWARE-Spam-Status: No, hits=2.9 required=5.0 tests=AWL,BAYES_00,BOTNET,RCVD_IN_JMF_BL,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout1.012.net.il (HELO mtaout1.012.net.il) (84.95.2.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 01 May 2009 09:26:48 +0000 Received: from conversion-daemon.i-mtaout1.012.net.il by i-mtaout1.012.net.il (HyperSendmail v2007.08) id <0KIY00B00KPZ0800@i-mtaout1.012.net.il> for gdb-patches@sourceware.org; Fri, 01 May 2009 12:26:45 +0300 (IDT) Received: from HOME-C4E4A596F7 ([77.127.230.216]) by i-mtaout1.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KIY008HCKWKDOD0@i-mtaout1.012.net.il>; Fri, 01 May 2009 12:26:45 +0300 (IDT) Date: Fri, 01 May 2009 09:26:00 -0000 From: Eli Zaretskii Subject: Re: Process record and replay checked in to main trunk In-reply-to: To: Hui Zhu Cc: gdb-patches@sourceware.org, msnyder@vmware.com Reply-to: Eli Zaretskii Message-id: <831vr9dvhc.fsf@gnu.org> References: X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00012.txt.bz2 May I suggest the following changes in some of the doc strings related to this feature? In addition to rewording, it also reformats the way the strings are presented, so that it is easy to spot when we exceed the width of the screen and need to break long lines. 2009-05-01 Eli Zaretskii * record.c (_initialize_record): Reformat and clarify doc strings for stop-at-limit and insn-number-max. Index: gdb/record.c =================================================================== RCS file: /cvs/src/src/gdb/record.c,v retrieving revision 1.2 diff -u -r1.2 record.c --- gdb/record.c 30 Apr 2009 02:58:37 -0000 1.2 +++ gdb/record.c 1 May 2009 09:24:01 -0000 @@ -1259,28 +1259,21 @@ /* Record instructions number limit command. */ add_setshow_boolean_cmd ("stop-at-limit", no_class, - &record_stop_at_limit, - _("Set whether record/replay stop when " - "record/replay buffer becomes full."), - _("Show whether record/replay stop when " - "record/replay buffer becomes full."), - _("Enable is default value.\n" - "When enabled, if the record/replay buffer " - "becomes full,\n" - "ask user what to do.\n" - "When disabled, if the record/replay buffer " - "becomes full,\n" - "delete it and start new recording."), + &record_stop_at_limit, _("\ +Set whether record/replay stops when record/replay buffer becomes full."), _("\ +Show whether record/replay stops when record/replay buffer becomes full."), _("\ +Default is ON.\n\ +When ON, if the record/replay buffer becomes full, ask user what to do.\n\ +When OFF, if the record/replay buffer becomes full,\n\ +delete the oldest recorded instruction to make room for each new one."), NULL, NULL, &set_record_cmdlist, &show_record_cmdlist); add_setshow_zinteger_cmd ("insn-number-max", no_class, &record_insn_max_num, _("Set record/replay buffer limit."), - _("Show record/replay buffer limit."), - _("Set the maximum number of instructions to be " - "stored in the\n" - "record/replay buffer. " - "Zero means unlimited (default 200000)."), + _("Show record/replay buffer limit."), _("\ +Set the maximum number of instructions to be stored in the\n\ +record/replay buffer. Zero means unlimited. Default is 200000."), set_record_insn_max_num, NULL, &set_record_cmdlist, &show_record_cmdlist); add_cmd ("insn-number", class_obscure, show_record_insn_number,