From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-70323-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 4217 invoked by alias); 19 Feb 2010 14:28:41 -0000
Received: (qmail 4209 invoked by uid 22791); 19 Feb 2010 14:28:40 -0000
X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 	tests=AWL,BAYES_00,RCVD_IN_SORBS_WEB,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 19 Feb 2010 14:28:35 +0000
Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0KY300700ERLNQ00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Fri, 19 Feb 2010 16:28:28 +0200 (IST)
Received: from HOME-C4E4A596F7 ([84.228.213.68]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KY3005QLEVFXT60@a-mtaout20.012.net.il>; Fri, 19 Feb 2010 16:28:28 +0200 (IST)
Date: Fri, 19 Feb 2010 14:28:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [patch][python] Add symbol, symbol table and frame block support to GDB API
In-reply-to: <20100219141457.GB2602@localhost.localdomain>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: tromey@redhat.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <831vghxpwj.fsf@gnu.org>
References: <4B66DA35.7080701@redhat.com> <m3r5p0inxy.fsf@fleche.redhat.com> <4B796506.7010909@redhat.com> <m3hbpfdzqj.fsf@fleche.redhat.com> <20100219141457.GB2602@localhost.localdomain>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-02/txt/msg00482.txt.bz2

> Date: Fri, 19 Feb 2010 14:14:57 +0000
> From: Phil Muldoon <pmuldoon@redhat.com>
> Cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches ml <gdb-patches@sourceware.org>
> 
> +* Python scripting
> +
> +The GDB Python API now has access to symbols, symbol tables, and
> +frame's code blocks.
> +

This is okay, thanks.

> +@defmethod Frame block
> +Returns the frame's code block.  @xref{Blocks In Python}.
> +@end defmethod
> +
> +@defmethod Frame function
> +Returns the symbol for the function corresponding to this frame.
> +@xref{Symbols In Python}.
> +@end defmethod

Please use "Return" rather than "Returns".

> +Please see @ref{Frames In Python} for a more in-depth discussion on
> +frames.  Furthermore, see @ref{Stack, ,Examining the Stack} for more
> +detailed technical information on @value{GDBN}'s book-keeping of the
> +stack.

And still no comma after @ref{...}.