From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-70813-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 26778 invoked by alias); 6 Mar 2010 09:14:11 -0000
Received: (qmail 26769 invoked by uid 22791); 6 Mar 2010 09:14:10 -0000
X-SWARE-Spam-Status: No, hits=-0.8 required=5.0 	tests=AWL,BAYES_00,RCVD_IN_SORBS_WEB,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 06 Mar 2010 09:14:03 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0KYU00F00RWNPL00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Sat, 06 Mar 2010 11:13:38 +0200 (IST)
Received: from HOME-C4E4A596F7 ([77.126.34.234]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KYU00B80SAPXP90@a-mtaout22.012.net.il>; Sat, 06 Mar 2010 11:13:38 +0200 (IST)
Date: Sat, 06 Mar 2010 09:14:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: RFA: fix CLI/9591 (pagination and --batch)
In-reply-to: <m3k4tqs8z7.fsf@fleche.redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: pedro@codesourcery.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <831vfx4xt8.fsf@gnu.org>
References: <m3k4tqv8w0.fsf@fleche.redhat.com> <201003052050.51865.pedro@codesourcery.com> <m3k4tqs8z7.fsf@fleche.redhat.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-03/txt/msg00258.txt.bz2

> From: Tom Tromey <tromey@redhat.com>
> Cc: gdb-patches@sourceware.org
> Date: Fri, 05 Mar 2010 15:24:12 -0700
> 
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -1028,7 +1028,9 @@ Run in batch mode.  Exit with status @code{0} after processing all the
>  command files specified with @samp{-x} (and all commands from
>  initialization files, if not inhibited with @samp{-n}).  Exit with
>  nonzero status if an error occurs in executing the @value{GDBN} commands
> -in the command files.
> +in the command files.  Batch mode also disables pagination;
> +@pxref{Screen Size} and acts as if @code{set confirm off} were in
> +effect (@pxref{Messages/Warnings}).

This is okay, but please also add notes to the two referenced nodes
telling how the batch mode changes their respective defaults.

Oh, and please use @kbd{set confirm off}, as that would be a command
typed at the keyboard.

> +/* True if --batch or --batch-silent was seen.  */
> +int batch = 0;

Is it wise to have a global symbol with such a short and ``general''
name?  Previously, it was static, so that was probably okay.  Now it's
a true global, so it could potentially clash with some library.  I'd
suggest to rename it to something less invasive.

Thanks.