From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-76325-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 4326 invoked by alias); 4 Nov 2010 04:01:31 -0000
Received: (qmail 4317 invoked by uid 22791); 4 Nov 2010 04:01:30 -0000
X-SWARE-Spam-Status: No, hits=-0.8 required=5.0	tests=AWL,BAYES_00,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 04 Nov 2010 04:01:22 +0000
Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LBC00E00DR8F400@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Thu, 04 Nov 2010 06:01:16 +0200 (IST)
Received: from HOME-C4E4A596F7 ([77.126.249.126]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LBC00EHLDU3CV20@a-mtaout20.012.net.il>; Thu, 04 Nov 2010 06:01:16 +0200 (IST)
Date: Thu, 04 Nov 2010 04:01:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [patch, doc RFA] gdb.parameter("directories"), new "set dir" command
In-reply-to: <20101104010740.1942E2460AB@ruffy.mtv.corp.google.com>
To: dje@google.com (Doug Evans)
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <831v7168kw.fsf@gnu.org>
References: <20101104010740.1942E2460AB@ruffy.mtv.corp.google.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-11/txt/msg00082.txt.bz2

> Date: Wed,  3 Nov 2010 18:07:39 -0700 (PDT)
> From: dje@google.com (Doug Evans)
> 
> This patch does two things.
> - make python gdb.parameter("directories") work
> - new command "set directories"

Thanks.

>  *** Changes since GDB 7.2
>  
> +* GDB has a new command: "set directories".
> +  It is like the "dir" command except that it replaces the
> +  source path list instead of augmenting it.
> +
>  * Python scripting
>  
>    ** GDB values in Python are now callable if the value represents a
> @@ -25,6 +29,8 @@
>    ** New commands "info pretty-printers", "enable pretty-printer" and
>       "disable pretty-printer" have been added.
>  
> +  ** gdb.parameter("directories") is now available.
> +
>  * C++ Improvements:
>  
>    ** GDB now puts template parameters in scope when debugging in an

This part is fine with me.

> +GDB ensures the search path always ends with $cdir:$cwd by\n\
> +appending these paths if necessary.\n\
                   ^^^^^
"directories", not "paths", since the whole list is called "search
path".

> --- doc/gdb.texinfo	2 Nov 2010 22:44:12 -0000	1.771
> +++ doc/gdb.texinfo	4 Nov 2010 01:00:50 -0000
> @@ -6620,6 +6620,11 @@ Reset the source path to its default val
>  @c RET-repeat for @code{directory} is explicitly disabled, but since
>  @c repeating it would be a no-op we do not say that.  (thanks to RMS)
>  
> +@item set directories @var{path-list}
> +@kindex set directories
> +Set the source path to @var{path-list}.
> +@samp{$cdir:$cwd} are added if missing.

This part is OK.