From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-89967-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 15586 invoked by alias); 17 Apr 2012 16:55:31 -0000
Received: (qmail 15407 invoked by uid 22791); 17 Apr 2012 16:55:27 -0000
X-SWARE-Spam-Status: No, hits=-2.1 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,RCVD_IN_NIX_SPAM,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 17 Apr 2012 16:55:11 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0M2M00E00UYTO900@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Tue, 17 Apr 2012 19:55:09 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([84.229.57.204]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M2M00D92UZWTXG0@a-mtaout22.012.net.il>; Tue, 17 Apr 2012 19:55:09 +0300 (IDT)
Date: Tue, 17 Apr 2012 17:05:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFC - Python scripting] New methods Symtab.global_block and Symtab.static_block (docs included)
In-reply-to: <CAGyQ6gyuJ1oYBH3O5gzNc7Y7NK7AGC2F9a8Z3ts4dMm0GpVy0g@mail.gmail.com>
To: Siva Chandra <sivachandra@google.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <831unms3jy.fsf@gnu.org>
References: <CAGyQ6gyuJ1oYBH3O5gzNc7Y7NK7AGC2F9a8Z3ts4dMm0GpVy0g@mail.gmail.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-04/txt/msg00502.txt.bz2

> Date: Tue, 17 Apr 2012 12:55:43 +0530
> From: Siva Chandra <sivachandra@google.com>
> 
> +  ** New methods 'global_block' and 'static_block' on gdb.Symtab objects
> +     which return the global and static blocks (as gdb.Block objects),
> +     of the underlying symbol table, respectively.

This is OK.

> +@defun Symtab.global_block ()
> +Return the global block of the underlying symbol table.  Note that,
> +though highly unlikely, the returned @code{gdb.Block} objects are not
> +guaranteed to be identical across different @value{GDBN} releases.
> +@end defun
> +
> +@defun Symtab.static_block ()
> +Return the static block of the underlying symbol table.  Note that,
> +though highly unlikely, the returned @code{gdb.Block} objects are not
> +guaranteed to be identical across different @value{GDBN} releases.
> +@end defun

I think it would be a good idea to have here a cross-reference to
"Blocks in Python".

Also, the 2 identical sentences about the objects not being preserved
across GDB releases should probably be replaced by just one sentence,
saying this for both types of blocks.

The documentation parts are OK with those changes.

Thanks.