From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22422 invoked by alias); 19 Jun 2012 16:08:14 -0000 Received: (qmail 22403 invoked by uid 22791); 19 Jun 2012 16:08:12 -0000 X-SWARE-Spam-Status: No, hits=-3.9 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,RCVD_IN_NIX_SPAM,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 19 Jun 2012 16:07:59 +0000 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0M5V00D00GR1XH00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Tue, 19 Jun 2012 19:07:37 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.210.75]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M5V00DEUGSONP60@a-mtaout20.012.net.il>; Tue, 19 Jun 2012 19:07:37 +0300 (IDT) Date: Tue, 19 Jun 2012 16:08:00 -0000 From: Eli Zaretskii Subject: Re: [RFA] Add global/static and symbol kind indicator to .gdb_index In-reply-to: <20120619074931.6F0B41E136F@ruffy2.mtv.corp.google.com> To: dje@google.com (Doug Evans) Cc: tromey@redhat.com, gdb-patches@sourceware.org, ccoutant@google.com Reply-to: Eli Zaretskii Message-id: <831ulbe14b.fsf@gnu.org> References: <20120619074931.6F0B41E136F@ruffy2.mtv.corp.google.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00618.txt.bz2 > cc: ccoutant@google.com > Date: Tue, 19 Jun 2012 00:49:31 -0700 (PDT) > From: dje@google.com (Doug Evans) > > This patch adds a global/static bit and a symbol kind indicator > to CU values in .gdb_index. Thanks. I have a few comments about the documentation part: > +If a symbol has multiple uses within a CU then there is one > +CU index+attributes value for each different use. I would lose the "different" part, it's redundant here. > +@item 0 > +This value is reserved and not to be used. ^^^^^^^^^^^^^^^^^^ "and should not be used" > +@item 2 > +The symbol is a variable. > +Enum values are also included. Not sure what the last sentence means. Value is not a symbol. Do you mean "the symbol is a name of a variable or of an enum"? And, if my reading of the code is correct, we should mention constants here. > +@item 4 > +The symbol is not covered by the other kinds. I think this is better: Any other kind of symbol. > +@item Bit 31 > +This bit is zero if the value is ``global'' and one if it is ``static''. Do we really need the quotes here?