From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-124578-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 129195 invoked by alias); 23 Jul 2015 17:24:53 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 129181 invoked by uid 89); 23 Jul 2015 17:24:52 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL,UNWANTED_LANGUAGE_BODY autolearn=no version=3.3.2
X-HELO: mtaout23.012.net.il
Received: from mtaout23.012.net.il (HELO mtaout23.012.net.il) (80.179.55.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Jul 2015 17:24:50 +0000
Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0NRY00400B0TK600@a-mtaout23.012.net.il> for gdb-patches@sourceware.org; Thu, 23 Jul 2015 20:24:47 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NRY004KHB1AF970@a-mtaout23.012.net.il>; Thu, 23 Jul 2015 20:24:47 +0300 (IDT)
Date: Thu, 23 Jul 2015 17:24:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH v11 5/7] gdbserver build-id attribute generator
In-reply-to: <20150723172154.1176.3682.stgit@host1.jankratochvil.net>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org, ARistovski@qnx.com, gbenson@redhat.com
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <831tfy4wiq.fsf@gnu.org>
References: <20150723172109.1176.3332.stgit@host1.jankratochvil.net> <20150723172154.1176.3682.stgit@host1.jankratochvil.net>
X-IsSubscribed: yes
X-SW-Source: 2015-07/txt/msg00649.txt.bz2

> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> Cc: Aleksandar Ristovski <ARistovski@qnx.com>,        Gary Benson <gbenson@redhat.com>
> Date: Thu, 23 Jul 2015 19:21:54 +0200
> 
> Producer part of the new "build-id" XML attribute.
> 
> gdb/ChangeLog
> 2015-07-15  Aleksandar Ristovski  <aristovski@qnx.com
> 	    Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	gdbserver build-id attribute generator.
> 	* features/library-list-svr4.dtd (library-list-svr4): New
> 	'build-id' attribute.
> 
> gdb/doc/ChangeLog
> 2015-07-15  Aleksandar Ristovski  <aristovski@qnx.com
> 	    Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	gdbserver build-id attribute generator.
> 	* gdb.texinfo (Library List Format for SVR4 Targets): Add
> 	'build-id' in description, example, new attribute in dtd.
> 
> gdb/gdbserver/ChangeLog
> 2015-07-15  Aleksandar Ristovski  <aristovski@qnx.com
> 	    Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	gdbserver build-id attribute generator.
> 	* linux-low.c (linux-maps.h, search.h, rsp-low.h): Include.
> 	(ElfXX_Ehdr, ElfXX_Phdr, ElfXX_Nhdr): New.
> 	(ELFXX_FLD, ELFXX_SIZEOF, ELFXX_ROUNDUP, BUILD_ID_INVALID): New.
> 	(find_phdr): New.
> 	(get_dynamic): Use find_pdhr to traverse program headers.
> 	(struct mapping_entry, mapping_entry_s, free_mapping_entry_vec)
> 	(compare_mapping_entry_range, struct find_memory_region_callback_data)
> 	(read_build_id, find_memory_region_callback, lrfind_mapping_entry)
> 	(get_hex_build_id): New.
> 	(linux_qxfer_libraries_svr4): Add optional build-id attribute
> 	to reply XML document.

The doco part is OK.

Thanks.