From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69120 invoked by alias); 22 Sep 2017 19:41:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 69111 invoked by uid 89); 22 Sep 2017 19:41:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 22 Sep 2017 19:41:25 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dvTpA-0005yG-JY for gdb-patches@sourceware.org; Fri, 22 Sep 2017 15:41:23 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46808) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvTpA-0005yC-Gp; Fri, 22 Sep 2017 15:41:20 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4889 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dvTp7-0004M9-U9; Fri, 22 Sep 2017 15:41:20 -0400 Date: Fri, 22 Sep 2017 19:41:00 -0000 Message-Id: <831smycyia.fsf@gnu.org> From: Eli Zaretskii To: Pedro Alves CC: sergiodj@redhat.com, gdb-patches@sourceware.org In-reply-to: (message from Pedro Alves on Fri, 22 Sep 2017 20:24:40 +0100) Subject: Re: [PATCH v3 4/5] Implement "set cwd" command on GDB Reply-to: Eli Zaretskii References: <20170912042325.14927-1-sergiodj@redhat.com> <20170921225926.23132-1-sergiodj@redhat.com> <20170921225926.23132-5-sergiodj@redhat.com> <83poajcg9a.fsf@gnu.org> <878th64nqk.fsf@redhat.com> <838th6d0l1.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00696.txt.bz2 > Cc: gdb-patches@sourceware.org > From: Pedro Alves > Date: Fri, 22 Sep 2017 20:24:40 +0100 > > (gdb) set cwd ~ # I haven't even connected to a target yet. > # Where should this be expanded? > # On host may be incorrect. > # '~' -> /home/pedro on this machine You can expand it when you connect. The value has no use until then anyway. > > Either way IMO is better than expanding at run > > time, because the latter makes the expansion dependent on factors > > which could be out of the user control, > > I don't see what the problem is here. > > > and also requires every use > > of the value to call gdb_tilde_expand, thus wasting cycles. > > I don't think that significant, compared to all the other > work / syscalls / remote protocol roundtrips that we have > to do to start a process. It may be insignificant in terms of CPU usage, but it's a nuisance that people will keep forgetting to do, as demonstrated in this case. Anyway, I will shut up now. I just feel that keeping this unexpanded is wrong in the long run, that's all.