Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Improve gcore manpage and clarify "-o" option
Date: Fri, 27 Jul 2018 06:08:00 -0000	[thread overview]
Message-ID: <831sbptdm3.fsf@gnu.org> (raw)
In-Reply-To: <20180727050234.20742-1-sergiodj@redhat.com> (message from Sergio	Durigan Junior on Fri, 27 Jul 2018 01:02:34 -0400)

> From: Sergio Durigan Junior <sergiodj@redhat.com>
> Cc: Eli Zaretskii <eliz@gnu.org>,
> 	Sergio Durigan Junior <sergiodj@redhat.com>
> Date: Fri, 27 Jul 2018 01:02:34 -0400
> 
> Ref.: https://bugs.debian.org/904628
> 
> It has been reported that gcore's manpage is a bit imprecise when it
> comes to two things:
> 
> - It doesn't explicity say that the command accepts more than one PID
>   on its CLI.
> 
> - It fails to mention that the argument passed through the "-o" option
>   is actually a prefix that will be used to compose the corefile's
>   filename, and not the actual filename.
> 
> I decided to give it a try and rewrite parts of the text to further
> clarify these two points.  I ended up rewording the "Description"
> section because, IMHO, it was a bit confuse to understand.
> 
> To make things consistent, I've also renamed the "$name" variable in
> the gcore.in script, and expanded the usage text.
> 
> gdb/doc/ChangeLog:
> yyyy-mm-dd  Sergio Durigan Junior  <sergiodj@redhat.com>
> 
> 	* gdb.texinfo (gcore man): Rewrite "Description" and "-o"
> 	option sections to further clarify that gcore can take more
> 	than one PID, and that "-o" is used to specify a prefix, not a
> 	filename.
> 
> gdb/ChangeLog:
> yyyy-mm-dd  Sergio Durigan Junior  <sergiodj@redhat.com>
> 
> 	* gcore.in: Rename variable "name" to "prefix".  Expand
> 	"usage" text.

This is OK, thanks.


  reply	other threads:[~2018-07-27  6:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-27  5:02 Sergio Durigan Junior
2018-07-27  6:08 ` Eli Zaretskii [this message]
2018-07-27 19:57   ` Sergio Durigan Junior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=831sbptdm3.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=sergiodj@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox