From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-151590-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 124599 invoked by alias); 13 Oct 2018 18:10:33 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 124550 invoked by uid 89); 13 Oct 2018 18:10:33 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:2001
X-HELO: eggs.gnu.org
Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 13 Oct 2018 18:10:32 +0000
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)	(envelope-from <eliz@gnu.org>)	id 1gBOMp-0007U4-8z	for gdb-patches@sourceware.org; Sat, 13 Oct 2018 14:10:28 -0400
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34262)	by eggs.gnu.org with esmtp (Exim 4.71)	(envelope-from <eliz@gnu.org>)	id 1gBOMf-0007NZ-RR; Sat, 13 Oct 2018 14:10:15 -0400
Received: from [176.228.60.248] (port=1310 helo=home-c4e4a596f7)	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)	(Exim 4.82)	(envelope-from <eliz@gnu.org>)	id 1gBOMf-0001pb-EC; Sat, 13 Oct 2018 14:10:13 -0400
Date: Sat, 13 Oct 2018 18:10:00 -0000
Message-Id: <831s8tvhtg.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: John Darrington <john@darrington.wattle.id.au>
CC: gdb-patches@sourceware.org
In-reply-to: <20181013175801.2670-3-john@darrington.wattle.id.au> (message	from John Darrington on Sat, 13 Oct 2018 19:58:00 +0200)
Subject: Re: [PATCH 3/4] GDB: Fix documentation for invoking GDBSERVER
References: <cc6ec9f9-20c0-ee07-7047-acd1801a2b1a@redhat.com> <20181013175801.2670-1-john@darrington.wattle.id.au> <20181013175801.2670-3-john@darrington.wattle.id.au>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2001:4830:134:3::e
X-IsSubscribed: yes
X-SW-Source: 2018-10/txt/msg00308.txt.bz2

> From: John Darrington <john@darrington.wattle.id.au>
> Cc: John Darrington <john@darrington.wattle.id.au>
> Date: Sat, 13 Oct 2018 19:58:00 +0200
> 
> The documentation did not mention the possibility of invoking gdbserver
> with the new connection forms such as tcp6:host:port.  This change fixes
> that.

Thanks.  Please see a few comments below.

> +@table @code
> +@item @code{@var{device}}
> +A serial line device.

Since your @table uses @code by default, there's no need to use @code
in each @item of the table.

> +@var{host} must either be the null string or the literal string @code{localhost}.

What is a "null string"?  Do you mean an empty string?

Thanks.