From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69800 invoked by alias); 15 Jan 2019 17:28:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 69678 invoked by uid 89); 15 Jan 2019 17:28:11 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=history X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 15 Jan 2019 17:28:08 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49791) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gjSVR-0005qJ-Pw; Tue, 15 Jan 2019 12:28:05 -0500 Received: from [176.228.60.248] (port=4146 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gjSVR-0004Td-Cx; Tue, 15 Jan 2019 12:28:05 -0500 Date: Tue, 15 Jan 2019 17:28:00 -0000 Message-Id: <831s5despw.fsf@gnu.org> From: Eli Zaretskii To: Simon Marchi CC: gdb-patches@sourceware.org In-reply-to: <20190114203902.11490-1-simon.marchi@ericsson.com> (message from Simon Marchi on Mon, 14 Jan 2019 20:39:16 +0000) Subject: Re: [PATCH] doc: Add table of MI versions References: <20190114203902.11490-1-simon.marchi@ericsson.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-01/txt/msg00349.txt.bz2 > From: Simon Marchi > CC: Simon Marchi > Date: Mon, 14 Jan 2019 20:39:16 +0000 > > This patch adds a table summarizing the history or MI versions: > > - The version number > - Which GDB version introduced it > - Breaking changes compared to the previous version Thanks. > -Although @sc{gdb/mi} is still incomplete, it is currently being used > -by a variety of front ends to @value{GDBN}. This makes it difficult > -to introduce new functionality without breaking existing usage. This > -section tries to minimize the problems by describing how the protocol > -might change. > +The MI interface is versioned, allowing it to evolve while avoiding breaking > +existing front ends. Some of the rationale you removed sounds like something good to have. Explaining the rationale for a section is in general a Good Thing, IMO. > If the changes are likely to break front ends, the MI version level > -will be increased by one. This will allow the front end to parse the > -output according to the MI version. Apart from mi0, new versions of > -@value{GDBN} will not support old versions of MI and it will be the > -responsibility of the front end to work with the new one. > +will be increased by one. Previous versions of MI remain available, allowing > +front ends to keep using them until they are modified to use the latest MI > +version. Likewise here: the old text explained that miN version will generally be incompatible with miN-1 version. Your change removes that important statement. I'd prefer not to lose that part. > -@c Starting with mi3, add a new command -mi-version that prints the MI > -@c version? Why did you remove the comment? It seems like a valid idea, perhaps worth implementing. > +Since @code{--interpreter=mi} always points to the latest MI version, it is > +recommended that front ends request a specific version of MI when launching > +@value{GDBN} (e.g. @code{--interpreter=mi2}) to make sure to get an interpreter ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ "to make sure they get and interpreter ..." > +The @code{-environment-pwd}, @code{-environment-directory} and > +@code{-environment-path} commands now returns values using the MI output > +syntax, rather than CLI output. ^^^^^^^^^^ "CLI output syntax", I presume. > +@item > +@code{-var-list-children}'s @code{children} result field is a now list, rather ^^^^^^^^ A typo.