From: Eli Zaretskii <eliz@gnu.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2 1/2] guile: Add support for Guile 2.2.
Date: Mon, 15 Jun 2020 20:00:53 +0300 [thread overview]
Message-ID: <831rmg2ri2.fsf@gnu.org> (raw)
In-Reply-To: <20200615151453.795-2-ludo@gnu.org> (message from Ludovic =?utf-8?Q?Court=C3=A8s?= on Mon, 15 Jun 2020 17:14:52 +0200)
> From: Ludovic Courtès <ludo@gnu.org>
> Date: Mon, 15 Jun 2020 17:14:52 +0200
> Cc: Ludovic Courtès <ludo@gnu.org>
>
> This primarily updates code that uses the I/O port API of Guile.
>
> gdb/ChangeLog
> 2020-06-15 Ludovic Courtès <ludo@gnu.org>
> Doug Evans <dje@google.com>
>
> PR gdb/21104
> * guile/scm-ports.c (USING_GUILE_BEFORE_2_2): New macro.
> (ioscm_memory_port)[read_buf_size, write_buf_size]: Wrap in #if
> USING_GUILE_BEFORE_2_2.
> (stdio_port_desc, memory_port_desc) [!USING_GUILE_BEFORE_2_2]:
> Change type to 'scm_t_port_type *'.
> (natural_buffer_size) [!USING_GUILE_BEFORE_2_2]: New variable.
> (ioscm_open_port) [USING_GUILE_BEFORE_2_2]: Add 'stream'
> parameter and honor it. Update callers.
> (ioscm_open_port) [!USING_GUILE_BEFORE_2_2]: New function.
> (ioscm_read_from_port, ioscm_write) [!USING_GUILE_BEFORE_2_2]: New
> functions.
> (ioscm_fill_input, ioscm_input_waiting, ioscm_flush): Wrap in #if
> USING_GUILE_BEFORE_2_2.
> (ioscm_init_gdb_stdio_port) [!USING_GUILE_BEFORE_2_2]: Use
> 'ioscm_read_from_port'. Call 'scm_set_port_read_wait_fd'.
> (ioscm_init_stdio_buffers) [!USING_GUILE_BEFORE_2_2]: New function.
> (gdbscm_stdio_port_p) [!USING_GUILE_BEFORE_2_2]: Use 'SCM_PORTP'
> and 'SCM_PORT_TYPE'.
> (gdbscm_memory_port_end_input, gdbscm_memory_port_seek)
> (ioscm_reinit_memory_port): Wrap in #if USING_GUILE_BEFORE_2_2.
> (gdbscm_memory_port_read, gdbscm_memory_port_write)
> (gdbscm_memory_port_seek, gdbscm_memory_port_close)
> [!USING_GUILE_BEFORE_2_2]: New functions.
> (gdbscm_memory_port_print): Remove use of 'SCM_PTOB_NAME'.
> (ioscm_init_memory_port_type) [!USING_GUILE_BEFORE_2_2]: Use
> 'gdbscm_memory_port_read'.
> Wrap 'scm_set_port_end_input', 'scm_set_port_flush', and
> 'scm_set_port_free' calls in #if USING_GUILE_BEFORE_2_2.
> (gdbscm_get_natural_buffer_sizes) [!USING_GUILE_BEFORE_2_2]: New
> function.
> (ioscm_init_memory_port): Remove.
> (ioscm_init_memory_port_stream): New function
> (ioscm_init_memory_port_buffers) [USING_GUILE_BEFORE_2_2]: New
> function.
> (gdbscm_memory_port_read_buffer_size) [!USING_GUILE_BEFORE_2_2]:
> Return scm_from_uint (0).
> (gdbscm_set_memory_port_read_buffer_size_x)
> [!USING_GUILE_BEFORE_2_2]: Call 'scm_setvbuf'.
> (gdbscm_memory_port_write_buffer_size) [!USING_GUILE_BEFORE_2_2]:
> Return scm_from_uint (0).
> (gdbscm_set_memory_port_write_buffer_size_x)
> [!USING_GUILE_BEFORE_2_2]: Call 'scm_setvbuf'.
> * testsuite/gdb.guile/scm-error.exp ("source
> $remote_guile_file_1"): Relax error regexp to match on Guile 2.2.
> * configure.ac (try_guile_versions): Add "guile-2.2".
> * configure: Regenerate.
> * NEWS: Add entry.
>
> gdb/doc/ChangeLog
> 2020-06-15 Ludovic Courtès <ludo@gnu.org>
>
> * guile.texi (Memory Ports in Guile): Remove
> documentation of 'memory-port-read-buffer-size',
> 'set-memory-port-read-buffer-size!',
> 'memory-port-write-buffer-size',
> 'set-memory-port-read-buffer-size!', which are no longer
> supported with Guile 2.2/3.0 and superseded by 'setvbuf'.
> * doc/guile.texi (Guile Introduction): Clarify which Guile
> versions are supported.
The documentation parts are okay, thanks.
I still am not convinced we should remove the description of those
functions from the manual, but I'll let others speak up if they have
an opinion.
next prev parent reply other threads:[~2020-06-15 17:01 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 13:27 [PATCH 0/2] Add support for Guile 3.0 and 2.2 Ludovic Courtès
2020-06-12 13:27 ` [PATCH 1/2] guile: Add support for Guile 2.2 Ludovic Courtès
2020-06-12 13:50 ` Eli Zaretskii
2020-06-12 14:04 ` Ludovic Courtès
2020-06-13 6:44 ` Eli Zaretskii
2020-06-13 15:04 ` Ludovic Courtès
2020-06-15 15:14 ` [PATCH v2 0/2] Add support for Guile 3.0 and 2.2 Ludovic Courtès
2020-06-15 15:14 ` [PATCH v2 1/2] guile: Add support for Guile 2.2 Ludovic Courtès
2020-06-15 17:00 ` Eli Zaretskii [this message]
2020-06-18 20:31 ` Tom Tromey
2020-06-19 6:08 ` Eli Zaretskii
2020-06-19 7:37 ` Ludovic Courtès
2020-06-26 8:13 ` [PATCH v3 0/2] Add support for Guile 3.0 and 2.2 Ludovic Courtès
2020-06-26 8:13 ` [PATCH v3 1/2] guile: Add support for Guile 2.2 Ludovic Courtès
2020-06-26 10:23 ` Eli Zaretskii
2020-06-28 14:20 ` Ludovic Courtès
2020-06-28 14:25 ` [PATCH v4 " Ludovic Courtès
2020-06-28 16:40 ` Eli Zaretskii
2020-07-03 0:31 ` Simon Marchi
2020-07-03 7:06 ` Ludovic Courtès
2020-07-18 19:00 ` Joel Brobecker
2020-07-19 15:45 ` Simon Marchi
2020-07-20 8:05 ` Ludovic Courtès
2020-07-20 15:01 ` Simon Marchi
2020-07-21 21:10 ` Ludovic Courtès
2020-06-28 14:25 ` [PATCH v4 2/2] guile: Add support for Guile 3.0 Ludovic Courtès
2020-06-28 16:38 ` [PATCH v3 1/2] guile: Add support for Guile 2.2 Eli Zaretskii
2020-06-28 16:51 ` Ludovic Courtès
2020-07-02 12:57 ` [PING] Add support for Guile 2.2/3.0 Ludovic Courtès
2020-07-13 15:36 ` Tom Tromey
2020-06-26 8:13 ` [PATCH v3 2/2] guile: Add support for Guile 3.0 Ludovic Courtès
2020-06-26 10:13 ` Eli Zaretskii
2020-06-15 15:14 ` [PATCH v2 " Ludovic Courtès
2020-06-12 14:14 ` [PATCH 1/2] guile: Add support for Guile 2.2 Tom de Vries
2020-06-12 14:36 ` Ludovic Courtès
2020-06-12 13:27 ` [PATCH 2/2] guile: Add support for Guile 3.0 Ludovic Courtès
2020-06-15 15:02 ` Tom Tromey
2020-06-15 15:17 ` Ludovic Courtès
2020-06-17 16:58 ` Ludovic Courtès
2020-06-17 17:21 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831rmg2ri2.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox