Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Alan Hayward <Alan.Hayward@arm.com>
Cc: GDB Patches <gdb-patches@sourceware.org>, nd <nd@arm.com>
Subject: Re: [PATCH v3 3/3] Aarch64: Fix segfault when casting dummy calls
Date: Mon, 29 Oct 2018 18:13:00 -0000	[thread overview]
Message-ID: <830e7c3b-3469-6cea-61d1-5a1e7e230de1@redhat.com> (raw)
In-Reply-To: <A4931C82-E629-460E-989D-B67979448B8E@arm.com>

On 10/29/2018 02:56 PM, Alan Hayward wrote:

> A-ha! Now I understand why I get two calls into _push_dummy_call.
> 
> So to answer your question, the TYPE_CODE_PTR->TYPE_CODE_INT is the malloc call.
> 
> Then the next call to _push_dummy_call has a return type of 0, as expected.
> This doesn’t segfault because it goes into language_pass_by_reference which
> routes to default_pass_by_reference. The same as the C shared library version.
> 
> 
> I’ve updated the test so it does {c,c++}*{debug nodebug}.
> I can also update it to do both shared lib and non shared lib too. That should
> cover everything.
But still, why do you see a difference between shared library and non-shared
library?

Thanks,
Pedro Alves


  reply	other threads:[~2018-10-29 18:13 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-11 14:49 [PATCH v3 0/3] " Alan Hayward
2018-10-11 14:49 ` [PATCH v3 2/3] Pass return_method to _push_dummy_call Alan Hayward
2018-10-19 11:31   ` Pedro Alves
2018-10-11 14:49 ` [PATCH v3 1/3] Use enum for return method for dummy calls Alan Hayward
2018-10-19 11:28   ` Pedro Alves
2018-10-11 14:49 ` [PATCH v3 3/3] Aarch64: Fix segfault when casting " Alan Hayward
2018-10-19 11:36   ` Pedro Alves
2018-10-23 16:08     ` Alan Hayward
2018-10-24 15:15       ` Pedro Alves
2018-10-29 11:58         ` Alan Hayward
     [not found]           ` <862cf8f4-9491-a1eb-251e-6c7c1ffffa6c@redhat.com>
2018-10-29 14:56             ` Alan Hayward
2018-10-29 18:13               ` Pedro Alves [this message]
2018-10-30 11:13                 ` Alan Hayward
2018-10-30 16:31                   ` Pedro Alves
2018-10-30 17:09                     ` Alan Hayward
2018-10-30 17:40                       ` Pedro Alves
2018-10-18  9:50 ` [PING][PATCH v3 0/3] " Alan Hayward

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=830e7c3b-3469-6cea-61d1-5a1e7e230de1@redhat.com \
    --to=palves@redhat.com \
    --cc=Alan.Hayward@arm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=nd@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox