From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41683 invoked by alias); 26 Jan 2017 13:17:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 41160 invoked by uid 89); 26 Jan 2017 13:17:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.1 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=fred, Fred, fish X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 26 Jan 2017 13:17:45 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 45816C04B302; Thu, 26 Jan 2017 13:17:45 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v0QDHei9012429; Thu, 26 Jan 2017 08:17:44 -0500 Subject: Re: [PATCH] Harden tests that deal with memory regions To: Luis Machado , gdb-patches@sourceware.org References: <1485206680-4402-1-git-send-email-lgustavo@codesourcery.com> From: Pedro Alves Message-ID: <830534b5-d820-d6dd-3d80-3644fcf50f5e@redhat.com> Date: Thu, 26 Jan 2017 13:17:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1485206680-4402-1-git-send-email-lgustavo@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-01/txt/msg00565.txt.bz2 On 01/23/2017 09:24 PM, Luis Machado wrote: > 2017-01-23 Luis Machado > > * lib/gdb-memory.exp: New file. Do we need "gdb-" in the file name? What other procedures to you envision being placed here? Should this have "regions" in the file name, like "memory-regions.exp"? The file's intro comment talks about memory regions. > * lib/gdb.exp: Load gdb-memory.exp Missing period. > --- a/gdb/testsuite/gdb.base/breakpoint-in-ro-region.exp > +++ b/gdb/testsuite/gdb.base/breakpoint-in-ro-region.exp > @@ -137,6 +137,9 @@ if ![get_function_bounds "main" main_lo main_hi] { > return -1 > } > > +# Delete all memory regions. > +delete_memory_regions > + The comment as-is practically just reads the function name in English. The important detail missing here is "target-supplied". So: # Delete all target-supplied memory regions. delete_memory_regions Likewise in the other spot. > gdb_test_no_output "mem 0x30 0x0 ro" > with_test_prefix "0x30 0x0" { > region_fail "0x20 0x50" > diff --git a/gdb/testsuite/lib/gdb-memory.exp b/gdb/testsuite/lib/gdb-memory.exp > new file mode 100644 > index 0000000..3377011 > --- /dev/null > +++ b/gdb/testsuite/lib/gdb-memory.exp > @@ -0,0 +1,38 @@ > +# Copyright 2017 Free Software Foundation, Inc. The file's non-boilerplate code is copyright 2012, so preserve that. (git show 1591a1e8) > + > +# This program is free software; you can redistribute it and/or modify > +# it under the terms of the GNU General Public License as published by > +# the Free Software Foundation; either version 3 of the License, or > +# (at your option) any later version. > +# > +# This program is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program. If not, see . > + > +# This file was written by Fred Fish. (fnf@cygnus.com) No it wasn't. > + > +# Generic gdb subroutines that should work for any target. If these > +# need to be modified for any target, it can be done with a variable > +# or by passing arguments. Stale comment. > + > +# This file holds functions and data dealing with memory regions manipulation. > + > +# Deletes all the memory regions GDB currently knows about. > + > +proc delete_memory_regions {} { Thanks, Pedro Alves