From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) by sourceware.org (Postfix) with ESMTPS id D80D6386F45A for ; Wed, 27 May 2020 12:39:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D80D6386F45A Received: by mail-qk1-x731.google.com with SMTP id 205so10979072qkg.3 for ; Wed, 27 May 2020 05:39:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=z+d8C/vBMgoNYkvgpB0yQzzSdHKvqaFWYiR+wRN8Z2M=; b=t5onnVvOC3yF++lsEJyjp1CJ40n5QIh/gyJRC8fh1weIagQYkYhw+YascsoT6HaBel 2LOQE7Zryu5hNmcNjCkjNibXWSxSrn3acRgycr80MUUh7VeXlEFr7ENlIdCEmXelKrjX CBllFgS6n2VUoNPIiexuPi0dJqR2nufCB4YoesK+n6h8KTevo/kcPg9dQS+WvLcqG5uY ZhfKP4tU0/jfHStjmg49pK/KC6Rd+2Wvt/B8HiPSDos2TnYQ04AsGVLA95kTuuZExJLG G4/J9YC8i7429JpTra8YQMNOEqu05S8g2rvVbdbPOf1sLv2ntEWJ5VPRDpD2N4nPhhN/ uPGw== X-Gm-Message-State: AOAM53368aKfYF743gi24BQ04K3RJZpRrAmb4B8S1uE8sHFQ8TbDlzH1 DrRsbkcA16FLYXFhaA6emlZLnzKpQsc= X-Google-Smtp-Source: ABdhPJzYxLVUTX5Yi8J9zOZfEol7fudu1wirgeFUv7C5mtRfEvLkmFb7rCni+5s/FstYyWURt8SWeQ== X-Received: by 2002:a37:d282:: with SMTP id f124mr3809765qkj.122.1590583159128; Wed, 27 May 2020 05:39:19 -0700 (PDT) Received: from [192.168.0.185] ([191.34.87.30]) by smtp.gmail.com with ESMTPSA id l6sm2126554qkc.59.2020.05.27.05.39.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 May 2020 05:39:18 -0700 (PDT) Subject: Re: [PATCH,v3 testsuite] Fix some duplicate test names To: Pedro Alves , gdb-patches@sourceware.org References: <20200526141848.22771-1-luis.machado@linaro.org> <20200526190224.755-1-luis.machado@linaro.org> <935ac55c-e195-0aa7-c8ed-63e77f8f9c96@redhat.com> From: Luis Machado Message-ID: <82d942ff-efcc-49fd-c763-b57032df13f1@linaro.org> Date: Wed, 27 May 2020 09:39:14 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 May 2020 12:39:21 -0000 On 5/26/20 5:52 PM, Pedro Alves wrote: > On 5/26/20 9:23 PM, Luis Machado wrote: >> On 5/26/20 4:35 PM, Pedro Alves wrote: >>> On 5/26/20 8:02 PM, Luis Machado via Gdb-patches wrote: >>> >>>> @@ -45,10 +45,10 @@ proc break_at { breakpoint where } { >>>>         set test "break $breakpoint" >>>>       set bp 0 >>>> -    gdb_test_multiple "$test" "$test" { >>>> +    gdb_test_multiple "$test" "$test inserted as number $bp" { >>> >>> As discussed, this change should be backed out, and replaced with >>> with_test_prefix, right?  $bp is always zero here. >> >> Ugh... EWRONGPATCH, apologies. I must have mixed up the files when sending. This was already fixed. >> >> Follows the updated one (for sure). > > OK. > > Thanks, > Pedro Alves > Thanks for the review. I've pushed this now.