From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id E296F386F439 for ; Fri, 29 May 2020 12:55:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E296F386F439 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id C7851AC37; Fri, 29 May 2020 12:55:29 +0000 (UTC) Subject: Re: [PATCH v2 00/42] Share DWARF partial symtabs between objfiles From: Tom de Vries To: Simon Marchi , Pedro Alves , Simon Marchi , Tom Tromey , Simon Marchi via Gdb-patches References: <20200512210913.5593-1-simon.marchi@efficios.com> <875zcn1xwp.fsf@tromey.com> <5032927f-877b-100b-c3a7-55c78d3a7d7a@redhat.com> <058f6a56-4690-cfd8-ede4-a9bbafc85e1a@efficios.com> <28656eeb-c0b3-c601-f05c-14cfe5493a7e@redhat.com> <63f4d428-b0ec-26de-0265-31002b61f4dd@simark.ca> Autocrypt: addr=tdevries@suse.de; keydata= xsBNBF0ltCcBCADDhsUnMMdEXiHFfqJdXeRvgqSEUxLCy/pHek88ALuFnPTICTwkf4g7uSR7 HvOFUoUyu8oP5mNb4VZHy3Xy8KRZGaQuaOHNhZAT1xaVo6kxjswUi3vYgGJhFMiLuIHdApoc u5f7UbV+egYVxmkvVLSqsVD4pUgHeSoAcIlm3blZ1sDKviJCwaHxDQkVmSsGXImaAU+ViJ5l CwkvyiiIifWD2SoOuFexZyZ7RUddLosgsO0npVUYbl6dEMq2a5ijGF6/rBs1m3nAoIgpXk6P TCKlSWVW6OCneTaKM5C387972qREtiArTakRQIpvDJuiR2soGfdeJ6igGA1FZjU+IsM5ABEB AAHNH1RvbSBkZSBWcmllcyA8dGRldnJpZXNAc3VzZS5kZT7CwKsEEwEIAD4WIQSsnSe5hKbL MK1mGmjuhV2rbOJEoAUCXSW0JwIbAwUJA8JnAAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAh CRDuhV2rbOJEoBYhBKydJ7mEpsswrWYaaO6FXats4kSgc48H/Ra2lq5p3dHsrlQLqM7N68Fo eRDf3PMevXyMlrCYDGLVncQwMw3O/AkousktXKQ42DPJh65zoXB22yUt8m0g12xkLax98KFJ 5NyUloa6HflLl+wQL/uZjIdNUQaHQLw3HKwRMVi4l0/Jh/TygYG1Dtm8I4o708JS4y8GQxoQ UL0z1OM9hyM3gI2WVTTyprsBHy2EjMOu/2Xpod95pF8f90zBLajy6qXEnxlcsqreMaqmkzKn 3KTZpWRxNAS/IH3FbGQ+3RpWkNGSJpwfEMVCeyK5a1n7yt1podd1ajY5mA1jcaUmGppqx827 8TqyteNe1B/pbiUt2L/WhnTgW1NC1QDOwE0EXSW0JwEIAM99H34Bu4MKM7HDJVt864MXbx7B 1M93wVlpJ7Uq+XDFD0A0hIal028j+h6jA6bhzWto4RUfDl/9mn1StngNVFovvwtfzbamp6+W pKHZm9X5YvlIwCx131kTxCNDcF+/adRW4n8CU3pZWYmNVqhMUiPLxElA6QhXTtVBh1RkjCZQ Kmbd1szvcOfaD8s+tJABJzNZsmO2hVuFwkDrRN8Jgrh92a+yHQPd9+RybW2l7sJv26nkUH5Z 5s84P6894ebgimcprJdAkjJTgprl1nhgvptU5M9Uv85Pferoh2groQEAtRPlCGrZ2/2qVNe9 XJfSYbiyedvApWcJs5DOByTaKkcAEQEAAcLAkwQYAQgAJhYhBKydJ7mEpsswrWYaaO6FXats 4kSgBQJdJbQnAhsMBQkDwmcAACEJEO6FXats4kSgFiEErJ0nuYSmyzCtZhpo7oVdq2ziRKD3 twf7BAQBZ8TqR812zKAD7biOnWIJ0McV72PFBxmLIHp24UVe0ZogtYMxSWKLg3csh0yLVwc7 H3vldzJ9AoK3Qxp0Q6K/rDOeUy3HMqewQGcqrsRRh0NXDIQk5CgSrZslPe47qIbe3O7ik/MC q31FNIAQJPmKXX25B115MMzkSKlv4udfx7KdyxHrTSkwWZArLQiEZj5KG4cCKhIoMygPTA3U yGaIvI/BGOtHZ7bEBVUCFDFfOWJ26IOCoPnSVUvKPEOH9dv+sNy7jyBsP5QxeTqwxC/1ZtNS DUCSFQjqA6bEGwM22dP8OUY6SC94x1G81A9/xbtm9LQxKm0EiDH8KBMLfQ== Message-ID: <82d7e864-af33-9136-c7c3-33fd7b2ac063@suse.de> Date: Fri, 29 May 2020 14:55:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-17.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 May 2020 12:55:32 -0000 On 29-05-2020 12:23, Tom de Vries wrote: > On 27-05-2020 17:51, Simon Marchi wrote: >> On 2020-05-27 10:53 a.m., Simon Marchi wrote: >>> I added another patch to the series, see here: >>> >>> https://sourceware.org/pipermail/gdb-patches/2020-May/169065.html >>> >>> The gdb.base/infcall-nested-structs-c.exp / gdb.base/infcall-nested-structs-c++.exp failures >>> just appeared to be intermittent failures in the end. So I think that with this last patch, >>> the series would be good to go. >>> >>> Simon >>> >> >> All right, the series is now pushed! With such a change, I do expect some things to break, >> please let me know if you see some unexpected behavior chgange following this. >> > > Hi Simon, > > I'm working on enabling the .gdb_index for ada, and after rebasing that > patch series to recent master I ran into a failure with target board > cc-with-gdb-index I thought I hadn't seen before, in > gdb.ada/mi_catch_assert.exp and a few more similar ada test-case. > > I managed to minimize and de-mi the failure to: > ... > $ cat cmd.gdb > file > /data/gdb_versions/devel/build/gdb/testsuite/outputs/gdb.ada/mi_catch_assert/bla > file > /data/gdb_versions/devel/build/gdb/testsuite/outputs/gdb.ada/mi_catch_assert/bla > tbreak main > run > catch assert > cond 2 Global_Var = 2 > continue > $ gdb -batch -ex "set sysroot" -x=cmd.gdb > Temporary breakpoint 1 at 0x401f39: file > /data/gdb_versions/devel/build/gdb/testsuite/outputs/gdb.ada/mi_catch_assert/b~bla.adb, > line 132. > > Temporary breakpoint 1, main (argc=1, argv=0x7fffffffdb98, > envp=0x7fffffffdba8) at > /data/gdb_versions/devel/build/gdb/testsuite/outputs/gdb.ada/mi_catch_assert/b~bla.adb:132 > 132 Ensure_Reference : aliased System.Address := > Ada_Main_Program_Name'Address; > Catchpoint 2: failed Ada assertions > > Catchpoint 2, failed assertion at <__gnat_debug_raise_assert_failure> () > at s-excdeb.adb:64 > 64 s-excdeb.adb: Bestand of map bestaat niet. > ... > while the expected output is: > ... > Catchpoint 2, failed assertion at 0x000000000040200a in bla () at > /data/gdb_versions/devel/binutils-gdb.git/gdb/testsuite/gdb.ada/mi_catch_assert/bla.adb:32 > 32 pragma Assert (Global_Var = 1, "Error #2"); -- STOP > ... > > Seeing the repetition of file command in the cmd.gdb file (and how > commenting out one of them made the test pass), I started suspecting > this patch series, and wondered if I could reproduce the same or similar > problems on master using a test-suite hack: > ... > diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp > index 444cea01c3..fa2a999525 100644 > --- a/gdb/testsuite/lib/gdb.exp > +++ b/gdb/testsuite/lib/gdb.exp > @@ -4823,7 +4823,12 @@ proc gdb_load_shlib { file } { > # > proc gdb_load { arg } { > if { $arg != "" } { > - return [gdb_file_cmd $arg] > + set res [gdb_file_cmd $arg] > + if { $res != 0 } { > + return $res > + } > + set res [gdb_file_cmd $arg] > + return $res > } > return 0 > } > ... > > And indeed, quite a few failures showed up. I picked one: > gdb.base/langs.exp. > > So, on master, after this patch series, with target board > cc-with-gdb-index, we have: > ... > Running /data/gdb_versions/devel/src/gdb/testsuite/gdb.base/langs.exp ... > FAIL: gdb.base/langs.exp: up to foo in langs.exp > FAIL: gdb.base/langs.exp: show language at foo in langs.exp > FAIL: gdb.base/langs.exp: up to cppsub_ in langs.exp > FAIL: gdb.base/langs.exp: show language at cppsub_ in langs.exp > FAIL: gdb.base/langs.exp: up to fsub in langs.exp > FAIL: gdb.base/langs.exp: show language at fsub in langs.exp > > === gdb Summary === > > # of expected passes 10 > # of unexpected failures 6 > ... > while with native we have: > ... > Running /data/gdb_versions/devel/src/gdb/testsuite/gdb.base/langs.exp ... > > === gdb Summary === > > # of expected passes 16 > ... > > Before this patch series, the test-case passes without any FAILs with > target board cc-with-gdb-index. With the same test-suite hack in place, we have on master with native: ... Running /data/gdb_versions/devel/src/gdb/testsuite/gdb.base/index-cache.exp ... ERROR: Couldn't load /data/gdb_versions/devel/build/gdb/testsuite/outputs/gdb.base/index-cache/index-cache, other program already loaded (timeout). FAIL: gdb.base/index-cache.exp: test_cache_enabled_miss: check index-cache stats (GDB internal error) ERROR: Couldn't load /data/gdb_versions/devel/build/gdb/testsuite/outputs/gdb.base/index-cache/index-cache, other program already loaded (timeout). ... First sign of trouble, an assert: ... (gdb) kill^M The program is not being run.^M (gdb) file /data/gdb_versions/devel/build/gdb/testsuite/outputs/gdb.base/index-cache/index-cache^M Reading symbols from /data/gdb_versions/devel/build/gdb/testsuite/outputs/gdb.base/index-cache/index-cache...^M (gdb) kill^M The program is not being run.^M (gdb) file /data/gdb_versions/devel/build/gdb/testsuite/outputs/gdb.base/index-cache/index-cache^M Load new symbol table from "/data/gdb_versions/devel/build/gdb/testsuite/outputs/gdb.base/index-cache/index-cache"? (y or n) y^M Reading symbols from /data/gdb_versions/devel/build/gdb/testsuite/outputs/gdb.base/index-cache/index-cache...^M /data/gdb_versions/devel/src/gdb/dwarf2/read.c:2546: internal-error: void create_cus_from_index(dwarf2_per_bfd*, const gdb_byte*, offset_type, const gdb_byte*, offset_type): Assertion `per_bfd->all_comp_units.empty ()' failed.^M ... Thanks, - Tom