From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-135446-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 94830 invoked by alias); 30 Nov 2016 13:34:49 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 94799 invoked by uid 89); 30 Nov 2016 13:34:47 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 30 Nov 2016 13:34:46 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 6EE7333884F;	Wed, 30 Nov 2016 13:34:45 +0000 (UTC)
Received: from [127.0.0.1] (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAUDYi2M015558;	Wed, 30 Nov 2016 08:34:44 -0500
Subject: Re: [PATCH 22/22] Introduce enum_flag type for ui_out flags
To: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
References: <20161124152428.24725-1-simon.marchi@polymtl.ca> <20161124153228.25177-22-simon.marchi@polymtl.ca>
From: Pedro Alves <palves@redhat.com>
Message-ID: <82c0febd-7237-15c8-b952-8ef978b1cd8e@redhat.com>
Date: Wed, 30 Nov 2016 13:34:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <20161124153228.25177-22-simon.marchi@polymtl.ca>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2016-11/txt/msg00986.txt.bz2

On 11/24/2016 03:32 PM, Simon Marchi wrote:
> This patch changes the ui_out flags to be an enum flag.

OK.

>  
>  /* flags enum */
> -enum ui_flags
> +enum ui_out_flag
>    {
> -    ui_from_tty = 1,
>      ui_source_list = 2
>    };
>  
> +DEF_ENUM_FLAGS_TYPE (ui_out_flag, ui_out_flags);

Please add an "#include common/enum-flags.h", so the file
includes what it needs instead of relying on indirect includes.

Thanks,
Pedro Alves