Re: add set cp-abi command

Jim Ingham
2002-04-10T18:10:35Z

Daniel,

Yup... I hadn't carried over the last checkin from my apple gdb
repository to my fsf copy. Doh!...

On Tuesday, April 9, 2002, at 05:54 PM, Daniel Jacobowitz wrote:

> On Tue, Apr 09, 2002 at 05:27:19PM -0700, Jim Ingham wrote:
>> I got distracted from this for a little while... Here is a final
>> version with something in the texi file as well.
>>
>> ChangeLog:
>>
>> 2002-03-12 James Ingham <jingham@apple.com>
>>
>> * cp-abi.c (set_cp_abi_cmd, show_cp_abi_cmd,): New functions,
>> allow you to set & show cplus abi's in case gdb gets it wrong.
>> (set_cp_abi_as_auto_default): New function, set the "auto" abi
>> to be this abi.
>> (is_cp_abi_auto_p): New function, say whether the current abi
>> is the default or not.
>> (_initialize_cp_abi): Define the cp-abi switching commands.
>> * cp-abi.h: declare the new functions.
>> * minsyms.c (install_minimal_symbols): don't switch the cp_abi
>> unless the current abi is auto.
>> * gnu-v2-abi.c (_initialize_gnu_v2_abi): don't switch to
>> gnu-v2,
>> but set it as the auto_default instead.
>>
>> Okay to check in?
>
> I think we may have misplaced a revision here...
>
> ! internal_error (__FILE__, __LINE__,
> ! "Too many CP ABIs, please increase CP_ABI_MAX in
> cp-abi.c");
>
> C++ ABIs.
>
> ! char *longname; /* These two can't be const, because I need to */
> ! char *doc; /* change the name for the auto abi. */
>
> GNU comment formatting. Something like:
> /* These two are not constant because they are changed at runtime
> for the auto ABI. */
> char *longname;
> char *doc;

I think we agreed to just drop the comment here. OK?

>
>
> More importantly:
> ! if (cp_abi_is_auto_p ())
> ! set_cp_abi_as_auto_default ("gnu-v3");
>
> Shouldn't you lose the cp_abi_is_auto_p () check there?
>

This seems correct.

>
> If you agree with all three, feel free to update them and check it in.
>

Okay, need to fix the docs first, then...

Jim
--
Jim Ingham jingham@apple.com
Developer Tools - gdb
Apple Computer