Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
To: Alexander Fedotov <alfedotov@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/gdbsupport: Use LOCALAPPDATA for index cache on windows
Date: Tue, 8 Dec 2020 10:16:26 -0500	[thread overview]
Message-ID: <8287dce8-d577-966e-cb72-015d982f1340@polymtl.ca> (raw)
In-Reply-To: <CAN8C2Cq8bzmGtWbb9KQz5VEUF_e-CHTOM0RhNnB9YByaCa8C1Q@mail.gmail.com>



On 2020-12-08 10:12 a.m., Alexander Fedotov wrote:
> On Tue, Dec 8, 2020 at 6:10 PM Simon Marchi <simon.marchi@polymtl.ca> wrote:
>>
>> On 2020-12-08 9:51 a.m., Alexander Fedotov wrote:
>>> Well, I don't know if other GDB parts depend on the final name. I just
>>> followed common convention. If there are no such dependencies so I
>>> don't mind using your suggestion:)
>>
>> GDB doesn't depend on a particular directory, I think it's better to
>> follow the standards of the platform as much as possible.  Does the
>> attached patch look ok to you?
> Yes, looks good to me. Thank you.

Thanks, I pushed it.

Note that this is a small enough patch that it doesn't require a 
copyright assignment.  But if you ever plan on submitting larger 
patches, you will need one:

https://sourceware.org/gdb/wiki/ContributionChecklist#FSF_copyright_Assignment

Simon

  reply	other threads:[~2020-12-08 15:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-08 10:16 Alexander Fedotov via Gdb-patches
2020-12-08 14:46 ` Simon Marchi via Gdb-patches
2020-12-08 14:48   ` Simon Marchi via Gdb-patches
2020-12-08 14:51     ` Alexander Fedotov via Gdb-patches
2020-12-08 15:10       ` Simon Marchi via Gdb-patches
2020-12-08 15:12         ` Alexander Fedotov via Gdb-patches
2020-12-08 15:16           ` Simon Marchi via Gdb-patches [this message]
2020-12-08 15:31   ` Eli Zaretskii via Gdb-patches
2020-12-09  9:15     ` Alexander Fedotov via Gdb-patches
2020-12-09 12:45       ` Christian Biesinger via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8287dce8-d577-966e-cb72-015d982f1340@polymtl.ca \
    --to=gdb-patches@sourceware.org \
    --cc=alfedotov@gmail.com \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox