From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sonic314-19.consmr.mail.ir2.yahoo.com (sonic314-19.consmr.mail.ir2.yahoo.com [77.238.177.145]) by sourceware.org (Postfix) with ESMTPS id 8CECE3894E60 for ; Thu, 30 Apr 2020 11:46:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8CECE3894E60 X-YMail-OSG: psHeY6QVM1nqeAXE_HrLvXLJWBoSsfJBqvMYZcfkaIbMf7o3Y.P5td7evuOS8JF levL1k3V_DvZAh5tGNanaoAPU2KMoZ1116xCKYYw0JR6_iotRmSJvFeNXNB2wEK0L83FtZD7gDtn 8Hg3yb6A9RSkASPgOUUrqgsCVORIZG9B2M3Xo7o6B30chQylAGnElYSY.giSawQDOACU8f648aHk g9F9DHRMgPKNQ.BWzGk6wojdNw3VKjnZ1h5sZDsm0LXBwLUxtHpacsL5JbkmwEwInUbdVziEaRRl cMHZIxwfqzRpghbd27dK6EoMrlyqtdZaAPuA5d6y.I446GUf_LIWxGcxuAyW17XbvuatWP52yZVZ DxCu3CwqySSNqNTWREw5nUUaj.FKwSnRg79KKrPfU7Ylhv6qJGydHN2lIEUFiIWx3UqwHwXQrkpr pLZppOGn91L_zGw8_tWP_LWFbnfyMQh3S1XwAICtGhKF8Z9V2KhycewAqQz95ulEh9cmDao3mkFc tpRk8u1KJXVtRly7lrgfmUAfItFu6IScMobuEzHJhfFy0sJohj3zLV34VTay2Q1WoWTMtupV9C2K w9hSyzHTIP8KQoox5kSR2scdFwA262uz0ZcsbuCPPvjBpgEV2r7YzE4egcjFem6xRO5RW.CfuMbQ IX4UQGRNnZe4gfVWb3ouxZK666ybzFf6GNU8s1pWGGM.26hrpoRF5WfM9RtEUTwi30Sq4rbcB8wn dk34YBHMcWx4EWc52ebEyqrDulFn0dZKkxqDBu5RAZTorSP1yEZ6qZfibRncOyZn5dUWIXT1Gbcq EV6pzKxn720q0Qmt1JG0cuW_ZHCM7IJTuHQhtTNHNLiKs1cphc8KSbc8F1IrLsMcUyvd3NOinQHs p6xXZMaKixvIj0y.Bs3iHQSLosP.uE2d2IvGfblZfGc1PcPPILFuipg1awdsOZy9X2CoyQHBiwd0 GThHhJ_gXgjunr84_eB2yXlnQ0RVizp1cLsLguuBNQpNGPkXrfq17CLWvClDM_Q8BowOU7rNyjxv q2UAzx2pu7f59k61YPQ5bo40ZH1yyzlJgqVu.RMRI1yJ43cbRdHAhF5reYrECruQsvISM_OK1QyP X4KAIdxHO1.wKxz4Gt8e1WA9h97kqQDVgNbcjswmgseRA_uktRlQdHsCGEbqWS5i3YyFiiVYFzzA 4_CjSKPZ7i3kh1Seg45TcVeOyE12QvIGEU3b.3U6ZrSLHqS5Dy9nmwTt.2O__pkaKX_LzxpYVxD0 9qzI67IiP44TRI_07Ty.CDaVcdLUMvlSiunLwXned75bF2web69JpmpuFuhxt4.iAxhYh1z_h01. 6MO_fGYMbiz81L.mT Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.ir2.yahoo.com with HTTP; Thu, 30 Apr 2020 11:46:31 +0000 Date: Thu, 30 Apr 2020 11:46:30 +0000 (UTC) From: Hannes Domani To: Gdb-patches Message-ID: <826498232.5260317.1588247190590@mail.yahoo.com> In-Reply-To: <96600c7d-fa3c-3b0e-f213-7809a92e1de4@suse.de> References: <20200427125900.5587-1-ssbssa.ref@yahoo.de> <20200427125900.5587-1-ssbssa@yahoo.de> <86e4c9c8-77bc-00c0-526c-b2974e15d7b9@simark.ca> <509127707.4013029.1588157997483@mail.yahoo.com> <96600c7d-fa3c-3b0e-f213-7809a92e1de4@suse.de> Subject: Re: [PATCH v2][PR gdb/17320] Fix array pretty formatter MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.15756 YMailNorrin Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:71.0) Gecko/20100101 Firefox/71.0 X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Apr 2020 11:46:37 -0000 Am Mittwoch, 29. April 2020, 23:09:08 MESZ hat Tom de Vries Folgendes geschrieben: > On 29-04-2020 12:59, Hannes Domani via Gdb-patches wrote: > this caused: > ... > Running > /data/gdb_versions/devel/src/gdb/testsuite/gdb.python/py-format-string.ex= p > ... > FAIL: gdb.python/py-format-string.exp: format_string: lang_c: an_array > with option pretty_arrays: pretty_arrays=3Dtrue > FAIL: gdb.python/py-format-string.exp: format_string: lang_c: > an_array_with_repetition with option pretty_arrays: pretty_arrays=3Dtrue > FAIL: gdb.python/py-format-string.exp: format_string: lang_c: set print > array on: an_array: no opts > FAIL: gdb.python/py-format-string.exp: format_string: lang_c: set print > array on: an_array: str > FAIL: gdb.python/py-format-string.exp: format_string: lang_c: set print > array on: an_array with option pretty_arrays: pretty_arrays=3Dtrue > FAIL: gdb.python/py-format-string.exp: format_string: lang_c: set print > array on: an_array_with_repetition: no opts > FAIL: gdb.python/py-format-string.exp: format_string: lang_c: set print > array on: an_array_with_repetition: str > FAIL: gdb.python/py-format-string.exp: format_string: lang_c: set print > array on: an_array_with_repetition with option pretty_arrays: > pretty_arrays=3Dtrue > FAIL: gdb.python/py-format-string.exp: format_string: lang_c: an_array > with option array_indexes=3DTrue, pretty_arrays=3DTrue > FAIL: gdb.python/py-format-string.exp: format_string: lang_cpp: an_array > with option pretty_arrays: pretty_arrays=3Dtrue > FAIL: gdb.python/py-format-string.exp: format_string: lang_cpp: > an_array_with_repetition with option pretty_arrays: pretty_arrays=3Dtrue > FAIL: gdb.python/py-format-string.exp: format_string: lang_cpp: set > print array on: an_array: no opts > FAIL: gdb.python/py-format-string.exp: format_string: lang_cpp: set > print array on: an_array: str > FAIL: gdb.python/py-format-string.exp: format_string: lang_cpp: set > print array on: an_array with option pretty_arrays: pretty_arrays=3Dtrue > FAIL: gdb.python/py-format-string.exp: format_string: lang_cpp: set > print array on: an_array_with_repetition: no opts > FAIL: gdb.python/py-format-string.exp: format_string: lang_cpp: set > print array on: an_array_with_repetition: str > FAIL: gdb.python/py-format-string.exp: format_string: lang_cpp: set > print array on: an_array_with_repetition with option pretty_arrays: > pretty_arrays=3Dtrue > FAIL: gdb.python/py-format-string.exp: format_string: lang_cpp: an_array > with option array_indexes=3DTrue, pretty_arrays=3DTrue > >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 =3D=3D=3D gdb Summary =3D=3D=3D > > # of expected passes=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 960 > # of unexpected failures=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 18 I'm sorry about that, I didn't know that python has interface for the vario= us pretty printers (and I only tested gdb without python so far). I will send a patch to update the test for the new output format. On a related note, I'm not sure if the 'set print zero-values' patch will b= e accepted, but if yes, should this then also have a python equivalent? Hannes