From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124938 invoked by alias); 22 Jun 2017 13:13:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 124523 invoked by uid 89); 22 Jun 2017 13:13:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LOTSOFHASH,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: EUR01-VE1-obe.outbound.protection.outlook.com Received: from mail-ve1eur01on0047.outbound.protection.outlook.com (HELO EUR01-VE1-obe.outbound.protection.outlook.com) (104.47.1.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 Jun 2017 13:13:42 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com (10.160.211.19) by AM3PR08MB0101.eurprd08.prod.outlook.com (10.160.211.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1178.14; Thu, 22 Jun 2017 13:13:38 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::9063:8caa:1bc4:156f]) by AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::9063:8caa:1bc4:156f%14]) with mapi id 15.01.1178.023; Thu, 22 Jun 2017 13:13:38 +0000 From: Alan Hayward To: Yao Qi CC: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH] Remove MAX_REGISTER_SIZE from py-unwind.c Date: Thu, 22 Jun 2017 13:13:00 -0000 Message-ID: <82556349-1E8C-44C3-9FC9-68F15E36D4D4@arm.com> References: <86bmpgjso6.fsf@gmail.com> In-Reply-To: <86bmpgjso6.fsf@gmail.com> authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AM3PR08MB0101;7:xBFm+ibPu0aAYIqkCMoSp5OkYDo7GBHCXxY67S2znLNNoRtIzp4mCURKujh8eaj2p3+fYtT2plEy1Uv+46MebD77UteUYGAXnkw771kuq4u1CG//FjLl4cCsHzIjPoWOceMQGsnddLK9i4CozMKhizXM+VbSLZcCc+/MJ9fww/nhNCbJoXaeQweTCqYIZ89Fy3a2wD105JvmhnD9OzDU+TSRyK9vDc3UmGjpZ6pmqnIaf6DWd+KZdqjUVyAYrN8swPmymnCUH736OwWYWfrbwUQNN9Zmp8fDDsjbXUbN2gTmu77tyIyq6QbY4V1D1LAbfwr/zntSE2Uh6nvb5lJxx1nnbbpq9VWTwEqnwBFtJratRIxSpN3NnbZT+F+wSl9WisXOeI3TdYhWo6X0mgI+rcX9kvrKyMJiR5lUDWpDHagGiJm8CoMMA0JaSvkhK0jZE0Ug/4L+P9q81fEtaXn0KA55P8PyTyo4/DWqqGS4I3nlzKhkqU75GZ2VlRHZb83bxsnVF5giJGJo38eW19fsheZvGZAipfsRZ24Xx7EFRL9FSGX07Jf/WzPzj9/GRoa/tkD3ROfBCsccXQfjcxVHXkN3//zguir4imBjDBOrUUqLMRP8frIeOTtOieZLd9eaTVpMyoAoYC9WxT5KMCqyMRkN7Xzu5VjduJpfgCVj+ETp7nWNa+26rsFvEAUaX/pr8y/1fsxuoD3CPygh/U/W7C2jBRcLSuIKxGgz4VOLGOf6owBIp91nk5MNKrnMGnAn7+1Hojt/pK1Bs3+FEObipZbYq5X3SfwwftwwnniwdkA= x-ms-office365-filtering-correlation-id: a4575bc0-f281-4cbf-5f54-08d4b9707f4d x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081)(201702281549075);SRVR:AM3PR08MB0101; x-ms-traffictypediagnostic: AM3PR08MB0101: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(3002001)(6055026)(6041248)(20161123564025)(20161123558100)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123560025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:AM3PR08MB0101;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:AM3PR08MB0101; x-forefront-prvs: 03468CBA43 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(39850400002)(39400400002)(39410400002)(39450400003)(39840400002)(39860400002)(24454002)(305945005)(36756003)(66066001)(7736002)(6486002)(229853002)(478600001)(2906002)(2950100002)(6916009)(3280700002)(86362001)(1411001)(3660700001)(14454004)(72206003)(81166006)(8936002)(81156014)(189998001)(99286003)(6506006)(8676002)(54906002)(6512007)(3846002)(25786009)(5660300001)(4326008)(102836003)(6116002)(2900100001)(83716003)(33656002)(6436002)(6246003)(110136004)(38730400002)(5250100002)(53936002)(76176999)(54356999)(82746002)(39060400002)(50986999)(53546010);DIR:OUT;SFP:1101;SCL:1;SRVR:AM3PR08MB0101;H:AM3PR08MB0101.eurprd08.prod.outlook.com;FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <649D3BDAD698324080068C384C91E345@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jun 2017 13:13:38.7929 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR08MB0101 X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00644.txt.bz2 DQo+IE9uIDIyIEp1biAyMDE3LCBhdCAxMDowOCwgWWFvIFFpIDxxaXlhb2x0 Y0BnbWFpbC5jb20+IHdyb3RlOg0KPiANCj4gQWxhbiBIYXl3YXJkIDxBbGFu LkhheXdhcmRAYXJtLmNvbT4gd3JpdGVzOg0KPiANCj4+ICAgICBjYWNoZWRf ZnJhbWUNCj4+IC0gICAgICA9ICgoY2FjaGVkX2ZyYW1lX2luZm8gKikNCj4+ IC0JIHhtYWxsb2MgKHNpemVvZiAoKmNhY2hlZF9mcmFtZSkNCj4+IC0JCSAg KyByZWdfY291bnQgKiBzaXplb2YgKGNhY2hlZF9mcmFtZS0+cmVnWzBdKSkp Ow0KPj4gKyAgICAgID0gKChjYWNoZWRfZnJhbWVfaW5mbyAqKSB4bWFsbG9j IChzaXplb2YgKCpjYWNoZWRfZnJhbWUpKSk7DQo+IA0KPiBVc2UgWE5FVywg dGhlIGNvZGUgY2FuIGJlIHNob3J0ZXIsDQo+IA0KPj4gQEAgLTYwMSw2ICs1 OTEsMTMgQEAgc3RhdGljIHZvaWQNCj4+IHB5dXdfZGVhbGxvY19jYWNoZSAo c3RydWN0IGZyYW1lX2luZm8gKnRoaXNfZnJhbWUsIHZvaWQgKmNhY2hlKQ0K Pj4gew0KPj4gICBUUkFDRV9QWV9VTldJTkQgKDMsICIlczogZW50ZXIiLCBf X0ZVTkNUSU9OX18pOw0KPj4gKyAgY2FjaGVkX2ZyYW1lX2luZm8gKmNhY2hl ZF9mcmFtZSA9IChjYWNoZWRfZnJhbWVfaW5mbyAqKSBjYWNoZTsNCj4+ICsN Cj4+ICsgIGZvciAoaW50IGkgPSAwOyBjYWNoZWRfZnJhbWUtPnJlZ19jb3Vu dDsgaSsrKQ0KPj4gKyAgICB7DQo+PiArICAgICAgeGZyZWUgKGNhY2hlZF9m cmFtZS0+cmVnW2ldLmRhdGEpOw0KPj4gKyAgICB9DQo+IA0KPiBObyBuZWVk IHRvIHVzZSBicmFjZXMuDQo+IA0KPiBPdGhlcndpc2UsIHBhdGNoIGlzIGdv b2QgdG8gbWUuDQo+IA0KPiAtLSANCj4gWWFvICjpvZDlsKcpDQoNCg0KT2ss IHB1c2hlZCB3aXRoIGNoYW5nZXMgYXMgc3VnZ2VzdGVkLg0KDQpQYXRjaCBi ZWxvdy4NCg0KVGhhbmtzLA0KQWxhbi4NCg0KDQpkaWZmIC0tZ2l0IGEvZ2Ri L3B5dGhvbi9weS11bndpbmQuYyBiL2dkYi9weXRob24vcHktdW53aW5kLmMN CmluZGV4IGE1YzI4NzM2OTc5NDRjMTI5M2ZkZDlmODI2NWRkZTA3ODM3OGU2 YzIuLmRhMTcwM2VjZjJiODQzZDlhNjc5MGYwOTVlNjRjMjkxNTI4MGFlMzUg MTAwNjQ0DQotLS0gYS9nZGIvcHl0aG9uL3B5LXVud2luZC5jDQorKysgYi9n ZGIvcHl0aG9uL3B5LXVud2luZC5jDQpAQCAtNzMsMTUgKzczLDYgQEAgdHlw ZWRlZiBzdHJ1Y3QNCiAvKiBUaGUgZGF0YSB3ZSBrZWVwIGZvciBhIGZyYW1l IHdlIGNhbiB1bndpbmQ6IGZyYW1lIElEIGFuZCBhbiBhcnJheSBvZg0KICAg IChyZWdpc3Rlcl9udW1iZXIsIHJlZ2lzdGVyX3ZhbHVlKSBwYWlycy4gICov DQoNCi1zdHJ1Y3QgcmVnX2luZm8NCi17DQotICAvKiBSZWdpc3RlciBudW1i ZXIuICAqLw0KLSAgaW50IG51bWJlcjsNCi0NCi0gIC8qIFJlZ2lzdGVyIGRh dGEgYnl0ZXMgcG9pbnRlci4gICovDQotICBnZGJfYnl0ZSBkYXRhW01BWF9S RUdJU1RFUl9TSVpFXTsNCi19Ow0KLQ0KIHR5cGVkZWYgc3RydWN0DQogew0K ICAgLyogRnJhbWUgSUQuICAqLw0KQEAgLTkzLDcgKzg0LDcgQEAgdHlwZWRl ZiBzdHJ1Y3QNCiAgIC8qIExlbmd0aCBvZiB0aGUgYHJlZycgYXJyYXkgYmVs b3cuICAqLw0KICAgaW50IHJlZ19jb3VudDsNCg0KLSAgc3RydWN0IHJlZ19p bmZvIHJlZ1tdOw0KKyAgY2FjaGVkX3JlZ190IHJlZ1tdOw0KIH0gY2FjaGVk X2ZyYW1lX2luZm87DQoNCiBleHRlcm4gUHlUeXBlT2JqZWN0IHBlbmRpbmdf ZnJhbWVfb2JqZWN0X3R5cGUNCkBAIC00ODMsMTQgKzQ3NCwxNCBAQCBweXV3 X3ByZXZfcmVnaXN0ZXIgKHN0cnVjdCBmcmFtZV9pbmZvICp0aGlzX2ZyYW1l LCB2b2lkICoqY2FjaGVfcHRyLA0KICAgICAgICAgICAgICAgICAgICAgaW50 IHJlZ251bSkNCiB7DQogICBjYWNoZWRfZnJhbWVfaW5mbyAqY2FjaGVkX2Zy YW1lID0gKGNhY2hlZF9mcmFtZV9pbmZvICopICpjYWNoZV9wdHI7DQotICBz dHJ1Y3QgcmVnX2luZm8gKnJlZ19pbmZvID0gY2FjaGVkX2ZyYW1lLT5yZWc7 DQotICBzdHJ1Y3QgcmVnX2luZm8gKnJlZ19pbmZvX2VuZCA9IHJlZ19pbmZv ICsgY2FjaGVkX2ZyYW1lLT5yZWdfY291bnQ7DQorICBjYWNoZWRfcmVnX3Qg KnJlZ19pbmZvID0gY2FjaGVkX2ZyYW1lLT5yZWc7DQorICBjYWNoZWRfcmVn X3QgKnJlZ19pbmZvX2VuZCA9IHJlZ19pbmZvICsgY2FjaGVkX2ZyYW1lLT5y ZWdfY291bnQ7DQoNCiAgIFRSQUNFX1BZX1VOV0lORCAoMSwgIiVzIChmcmFt ZT0lcCwuLi4scmVnPSVkKVxuIiwgX19GVU5DVElPTl9fLCB0aGlzX2ZyYW1l LA0KICAgICAgICAgICAgICAgICAgICByZWdudW0pOw0KICAgZm9yICg7IHJl Z19pbmZvIDwgcmVnX2luZm9fZW5kOyArK3JlZ19pbmZvKQ0KICAgICB7DQot ICAgICAgaWYgKHJlZ251bSA9PSByZWdfaW5mby0+bnVtYmVyKQ0KKyAgICAg IGlmIChyZWdudW0gPT0gcmVnX2luZm8tPm51bSkNCiAgICAgICAgIHJldHVy biBmcmFtZV91bndpbmRfZ290X2J5dGVzICh0aGlzX2ZyYW1lLCByZWdudW0s IHJlZ19pbmZvLT5kYXRhKTsNCiAgICAgfQ0KDQpAQCAtNTY2LDEwICs1NTcs NyBAQCBweXV3X3NuaWZmZXIgKGNvbnN0IHN0cnVjdCBmcmFtZV91bndpbmQg KnNlbGYsIHN0cnVjdCBmcmFtZV9pbmZvICp0aGlzX2ZyYW1lLA0KICAgICBz YXZlZF9yZWcgKnJlZzsNCiAgICAgaW50IGk7DQoNCi0gICAgY2FjaGVkX2Zy YW1lDQotICAgICAgPSAoKGNhY2hlZF9mcmFtZV9pbmZvICopDQotCSB4bWFs bG9jIChzaXplb2YgKCpjYWNoZWRfZnJhbWUpDQotCQkgICsgcmVnX2NvdW50 ICogc2l6ZW9mIChjYWNoZWRfZnJhbWUtPnJlZ1swXSkpKTsNCisgICAgY2Fj aGVkX2ZyYW1lID0gWE5FVyAoY2FjaGVkX2ZyYW1lX2luZm8pOw0KICAgICBj YWNoZWRfZnJhbWUtPmdkYmFyY2ggPSBnZGJhcmNoOw0KICAgICBjYWNoZWRf ZnJhbWUtPmZyYW1lX2lkID0gdW53aW5kX2luZm8tPmZyYW1lX2lkOw0KICAg ICBjYWNoZWRfZnJhbWUtPnJlZ19jb3VudCA9IHJlZ19jb3VudDsNCkBAIC01 ODAsMTMgKzU2OCwxNCBAQCBweXV3X3NuaWZmZXIgKGNvbnN0IHN0cnVjdCBm cmFtZV91bndpbmQgKnNlbGYsIHN0cnVjdCBmcmFtZV9pbmZvICp0aGlzX2Zy YW1lLA0KICAgICAgICAgc3RydWN0IHZhbHVlICp2YWx1ZSA9IHZhbHVlX29i amVjdF90b192YWx1ZSAocmVnLT52YWx1ZSk7DQogICAgICAgICBzaXplX3Qg ZGF0YV9zaXplID0gcmVnaXN0ZXJfc2l6ZSAoZ2RiYXJjaCwgcmVnLT5udW1i ZXIpOw0KDQotICAgICAgICBjYWNoZWRfZnJhbWUtPnJlZ1tpXS5udW1iZXIg PSByZWctPm51bWJlcjsNCisJY2FjaGVkX2ZyYW1lLT5yZWdbaV0ubnVtID0g cmVnLT5udW1iZXI7DQoNCiAgICAgICAgIC8qIGB2YWx1ZScgdmFsaWRhdGlv biB3YXMgZG9uZSBiZWZvcmUsIGp1c3QgYXNzZXJ0LiAgKi8NCiAgICAgICAg IGdkYl9hc3NlcnQgKHZhbHVlICE9IE5VTEwpOw0KICAgICAgICAgZ2RiX2Fz c2VydCAoZGF0YV9zaXplID09IFRZUEVfTEVOR1RIICh2YWx1ZV90eXBlICh2 YWx1ZSkpKTsNCiAgICAgICAgIGdkYl9hc3NlcnQgKGRhdGFfc2l6ZSA8PSBN QVhfUkVHSVNURVJfU0laRSk7DQoNCisJY2FjaGVkX2ZyYW1lLT5yZWdbaV0u ZGF0YSA9IChnZGJfYnl0ZSAqKSB4bWFsbG9jIChkYXRhX3NpemUpOw0KICAg ICAgICAgbWVtY3B5IChjYWNoZWRfZnJhbWUtPnJlZ1tpXS5kYXRhLCB2YWx1 ZV9jb250ZW50cyAodmFsdWUpLCBkYXRhX3NpemUpOw0KICAgICAgIH0NCiAg IH0NCkBAIC02MDEsNiArNTkwLDExIEBAIHN0YXRpYyB2b2lkDQogcHl1d19k ZWFsbG9jX2NhY2hlIChzdHJ1Y3QgZnJhbWVfaW5mbyAqdGhpc19mcmFtZSwg dm9pZCAqY2FjaGUpDQogew0KICAgVFJBQ0VfUFlfVU5XSU5EICgzLCAiJXM6 IGVudGVyIiwgX19GVU5DVElPTl9fKTsNCisgIGNhY2hlZF9mcmFtZV9pbmZv ICpjYWNoZWRfZnJhbWUgPSAoY2FjaGVkX2ZyYW1lX2luZm8gKikgY2FjaGU7 DQorDQorICBmb3IgKGludCBpID0gMDsgY2FjaGVkX2ZyYW1lLT5yZWdfY291 bnQ7IGkrKykNCisgICAgeGZyZWUgKGNhY2hlZF9mcmFtZS0+cmVnW2ldLmRh dGEpOw0KKw0KICAgeGZyZWUgKGNhY2hlKTsNCiB9DQoNCmRpZmYgLS1naXQg YS9nZGIvcmVnY2FjaGUuaCBiL2dkYi9yZWdjYWNoZS5oDQppbmRleCBiMmU4 YTc0OWQ0ODY2MDhhOTBhODI1ODNlZDhjNzRhZDY4MWJhY2NiLi40YWY5ZmJk Y2RiY2RiNTA4YTc2ZDc1OGU3MDViOWZiNTAwODI5MWFmIDEwMDY0NA0KLS0t IGEvZ2RiL3JlZ2NhY2hlLmgNCisrKyBiL2dkYi9yZWdjYWNoZS5oDQpAQCAt MjMyLDYgKzIzMiwxNCBAQCBlbnVtIHJlZ2NhY2hlX2R1bXBfd2hhdA0KICAg cmVnY2FjaGVfZHVtcF9yZW1vdGUNCiB9Ow0KDQorLyogQSAocmVnaXN0ZXJf bnVtYmVyLCByZWdpc3Rlcl92YWx1ZSkgcGFpci4gICovDQorDQordHlwZWRl ZiBzdHJ1Y3QgY2FjaGVkX3JlZw0KK3sNCisgIGludCBudW07DQorICBnZGJf Ynl0ZSAqZGF0YTsNCit9IGNhY2hlZF9yZWdfdDsNCisNCiAvKiBUaGUgcmVn aXN0ZXIgY2FjaGUgZm9yIHN0b3JpbmcgcmF3IHJlZ2lzdGVyIHZhbHVlcy4g ICovDQoNCiBjbGFzcyByZWdjYWNoZQ0KZGlmZiAtLWdpdCBhL2dkYi9yZW1v dGUuYyBiL2dkYi9yZW1vdGUuYw0KaW5kZXggYjY2ZWNlZTdmNmRiOGUyYTY5 MWI5ZTEyZjZjZTMxNGRhMjJkNjllYi4uOGU4ZWU2Zjg3MDUwNjlhM2Y2OWZk OGM4ODNiN2VhMzdkYjVkZTg1MSAxMDA2NDQNCi0tLSBhL2dkYi9yZW1vdGUu Yw0KKysrIGIvZ2RiL3JlbW90ZS5jDQpAQCAtNjMxMSwxMiArNjMxMSw2IEBA IHJlbW90ZV9jb25zb2xlX291dHB1dCAoY2hhciAqbXNnKQ0KICAgZ2RiX2Zs dXNoIChnZGJfc3RkdGFyZyk7DQogfQ0KDQotdHlwZWRlZiBzdHJ1Y3QgY2Fj aGVkX3JlZw0KLXsNCi0gIGludCBudW07DQotICBnZGJfYnl0ZSAqZGF0YTsN Ci19IGNhY2hlZF9yZWdfdDsNCi0NCiBERUZfVkVDX08oY2FjaGVkX3JlZ190 KTsNCg0KIHR5cGVkZWYgc3RydWN0IHN0b3BfcmVwbHkNCg0K >From gdb-patches-return-140025-listarch-gdb-patches=sources.redhat.com@sourceware.org Thu Jun 22 13:22:13 2017 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 31823 invoked by alias); 22 Jun 2017 13:22:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 31805 invoked by uid 89); 22 Jun 2017 13:22:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 Jun 2017 13:22:10 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 97B6C30AF5D; Thu, 22 Jun 2017 13:22:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 97B6C30AF5D Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 97B6C30AF5D Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 832D46EE44; Thu, 22 Jun 2017 13:22:08 +0000 (UTC) Subject: Re: [PATCH] Remove MAX_REGISTER_SIZE from py-unwind.c To: Alan Hayward , Yao Qi References: <86bmpgjso6.fsf@gmail.com> <82556349-1E8C-44C3-9FC9-68F15E36D4D4@arm.com> Cc: "gdb-patches@sourceware.org" , nd From: Pedro Alves Message-ID: <8b641cf5-6cdc-5c4e-6f85-eb28f08bed9c@redhat.com> Date: Thu, 22 Jun 2017 13:22:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <82556349-1E8C-44C3-9FC9-68F15E36D4D4@arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg00645.txt.bz2 Content-length: 1993 On 06/22/2017 02:13 PM, Alan Hayward wrote: > Ok, pushed with changes as suggested. > > Patch below. Sorry, but this looks broken to me. cached_frame_info is using the trailing array idiom ... > @@ -93,7 +84,7 @@ typedef struct > /* Length of the `reg' array below. */ > int reg_count; > > - struct reg_info reg[]; > + cached_reg_t reg[]; > } cached_frame_info; > > > - cached_frame > - = ((cached_frame_info *) > - xmalloc (sizeof (*cached_frame) > - + reg_count * sizeof (cached_frame->reg[0]))); > + cached_frame = XNEW (cached_frame_info); but now you're not allocating enough space for the array elements... > cached_frame->gdbarch = gdbarch; > cached_frame->frame_id = unwind_info->frame_id; > cached_frame->reg_count = reg_count; > @@ -580,13 +568,14 @@ pyuw_sniffer (const struct frame_unwind *self, struct frame_info *this_frame, > struct value *value = value_object_to_value (reg->value); > size_t data_size = register_size (gdbarch, reg->number); > > - cached_frame->reg[i].number = reg->number; > + cached_frame->reg[i].num = reg->number; ... that you're accessing here and below. Valgrind probably shows the now-out-of-bounds accesses. > > /* `value' validation was done before, just assert. */ > gdb_assert (value != NULL); > gdb_assert (data_size == TYPE_LENGTH (value_type (value))); > gdb_assert (data_size <= MAX_REGISTER_SIZE); > > + cached_frame->reg[i].data = (gdb_byte *) xmalloc (data_size); > memcpy (cached_frame->reg[i].data, value_contents (value), data_size); > } > } > @@ -601,6 +590,11 @@ static void > pyuw_dealloc_cache (struct frame_info *this_frame, void *cache) > { > TRACE_PY_UNWIND (3, "%s: enter", __FUNCTION__); > + cached_frame_info *cached_frame = (cached_frame_info *) cache; > + > + for (int i = 0; cached_frame->reg_count; i++) > + xfree (cached_frame->reg[i].data); > + > xfree (cache); > } >