From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 64160 invoked by alias); 1 Jul 2019 19:25:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 64137 invoked by uid 89); 1 Jul 2019 19:25:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy= X-HELO: mail-wm1-f53.google.com Received: from mail-wm1-f53.google.com (HELO mail-wm1-f53.google.com) (209.85.128.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 01 Jul 2019 19:25:52 +0000 Received: by mail-wm1-f53.google.com with SMTP id n9so649658wmi.0 for ; Mon, 01 Jul 2019 12:25:51 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id r6sm679515wmh.11.2019.07.01.12.25.49 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Mon, 01 Jul 2019 12:25:49 -0700 (PDT) Subject: [users/palves/format_strings] Introduce string_field To: Tom Tromey References: <20190605020116.1550-1-tom@tromey.com> <1ee4bd6b-4cdf-f3a9-74af-0843bf123a8b@redhat.com> <87lfygi1x0.fsf@tromey.com> <32872d6a-15d6-9718-59ae-957694e114c9@redhat.com> <87imtjhj6b.fsf@tromey.com> <625cd0ba-058d-d4bf-8ba3-8676f335b0f3@redhat.com> <87blzbep47.fsf@tromey.com> <2180f72f-da10-5333-90a1-666ba3bd145e@redhat.com> <87imtjbrmx.fsf@tromey.com> <871s056yjw.fsf@tromey.com> <87wohx5hir.fsf@tromey.com> <4e543ef2-eec3-b82c-a84a-a107e1ef2bc2@redhat.com> <3ff7dd5c-334b-3bcc-e43e-a350b3008304@redhat.com> <87ef39psdu.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <8233d01b-271c-fb4a-7f6c-cb97f201e245@redhat.com> Date: Mon, 01 Jul 2019 19:25:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <87ef39psdu.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-07/txt/msg00028.txt.bz2 On 7/1/19 6:38 PM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> I'm not sure whether we could portably save the varargs like > Pedro> above, though. So that might be moot. > > I'm not sure it matters a whole lot. > > I looked through all the field_fmt calls, and many of them can be > replaced with some other call. > > The few that remain can be rewritten in terms of string_printf if need > be. > > Pedro> - uiout->text ("[Inferior "); > Pedro> - uiout->text (plongest (inf->num)); > Pedro> - uiout->text (" ("); > Pedro> - uiout->text (pidstr.c_str ()); > Pedro> - uiout->text (") exited with code "); > Pedro> - uiout->field_fmt ("exit-code", "0%o", (unsigned int) exitstatus); > Pedro> - uiout->text ("]\n"); > Pedro> + std::string exit_code_str > Pedro> + = string_printf ("0%o", (unsigned int) exitstatus); > Pedro> + uiout->message ("[Inferior %s (%s) exited with code %pF]\n", > Pedro> + plongest (inf->num), pidstr.c_str (), > Pedro> + string_field ("exit-code", exit_code_str.c_str ())); > > This is so much better. I merged this one to users/palves/format_strings too. Thanks, Pedro Alves