From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id F3/yLHzUuGAZHAAAWB0awg (envelope-from ) for ; Thu, 03 Jun 2021 09:09:16 -0400 Received: by simark.ca (Postfix, from userid 112) id AAAC31F163; Thu, 3 Jun 2021 09:09:16 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 42E8E1E01F for ; Thu, 3 Jun 2021 09:09:15 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E6D8E382E833 for ; Thu, 3 Jun 2021 13:09:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E6D8E382E833 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1622725754; bh=k3sc/VFChW9t/Tuq2Ll7ecqJrSfhgNoEKR/ESF5Rn/8=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=WSaSXR8km/9VIV1Su4F7YFdxbPtiT0IZ1hgrUQ0WoZ4qhd0ypCHxCyyZrYjbtazMt lyYv0v839oRRsCL8QkM7PCHJd7662DqPuTUuvhq1TKzqWGRz067m+Hg1ewFuXZJ3VF qoMuqerr4Vh1s1psluAioaSXsTOJtRya1FoESnEs= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id E32CF386FC1F for ; Thu, 3 Jun 2021 13:08:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E32CF386FC1F Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 153D8cit013970 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 3 Jun 2021 09:08:42 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 153D8cit013970 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id DC6041E01F; Thu, 3 Jun 2021 09:08:37 -0400 (EDT) Subject: Re: [PATCHv2 5/5] gdb: change info sources to group results by objfile To: Andrew Burgess , gdb-patches@sourceware.org References: Message-ID: <82206b1d-22c4-f331-a77b-df84fa421852@polymtl.ca> Date: Thu, 3 Jun 2021 09:08:37 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 3 Jun 2021 13:08:38 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2021-05-19 7:12 a.m., Andrew Burgess wrote: > @@ -4482,10 +4441,16 @@ info_sources_worker (struct ui_out *uiout, > { > output_tuple.emplace (uiout, nullptr); > uiout->field_string ("filename", objfile_name (objfile)); > + uiout->text (":\n"); > bool debug_fully_readin = !objfile->has_unexpanded_symtabs (); > - current_uiout->field_string ("debug-fully-read", > - (debug_fully_readin > - ? "true" : "false")); > + if (!debug_fully_readin) > + uiout->text ("(Full debug information has not yet been read " > + " for this file.)\n"); I just noticed the double space between "read" and "for." Simon